Closed
Bug 1576451
Opened 5 years ago
Closed 5 years ago
Port |Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules| to SeaMonkey
Categories
(SeaMonkey :: General, task)
SeaMonkey
General
Tracking
(seamonkey2.49esr unaffected, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.68
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.63 | --- | wontfix |
| seamonkey2.53 | --- | fixed |
| seamonkey2.57esr | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file)
|
14.47 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Port the following:
- Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules
Whilst here, make sure that the vim / indent information is set consistently across jsm files.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #9089711 -
Flags: review?(frgrahl)
Attachment #9089711 -
Flags: approval-comm-release?
Attachment #9089711 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9089711 [details] [diff] [review] Exported symbols lgtm
Attachment #9089711 -
Flags: review?(frgrahl)
Attachment #9089711 -
Flags: review+
Attachment #9089711 -
Flags: approval-comm-release?
Attachment #9089711 -
Flags: approval-comm-release+
Attachment #9089711 -
Flags: approval-comm-esr60?
Attachment #9089711 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5d889bf20fb6
Port Bug 1440284 "change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules" to SeaMonkey. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•5 years ago
|
||
Turned out to be mostly a 2.53 bug. For 2.57 and 2.68+ it is header changes only.
https://hg.mozilla.org/releases/comm-esr60/rev/0ecbd0a9f5f6667a43f4a8b60fa26156ae3e8cec
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.63:
--- → wontfix
Target Milestone: --- → seamonkey2.68
|
|
||
Comment 5•4 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•