1576624 - Introduce Resource API for listening to console messages, sources, ... from all the Targets

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Yulia Startsev [:yulia]]

Rather than listing on all panels, it would make sense for us to have a way to just listen to new processes as they are created. We can reuse onFront for this.

Some open questions:

• where do we start listening for new processes?
• how do we remove processes?

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - add listenforProcesses; r=ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - WIP

Depends on D43449

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - WIP option 2, using an object callback

Depends on D43449

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - WIP add listenForProcesses

Comment 5

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - WIP with resource API

Depends on D45533

Comment 6

[Yulia Startsev [:yulia]]

Attachment: Bug 1576624 - WIP old implementation resource API

Comment 7

[Alexandre Poirot [:ochameau]]

A siginificant part of this bug is going to be done in bug 1471754.
Once that is done we should revisit this bug as well as bug 1548557 in order to focus on resources (console messages, sources and elements) instead of only Targets (frame, process, worker).

Comment 8

[Alexandre Poirot [:ochameau]]

The Resource API would actually be similar to the TargetList. It would most likely take a TargetList as constructor argument.
And expose methods like:

• watchResources(["console", "network-request", "source"], { mayBeSomeFilterParams }, onResourceAvailable, onResourceDestroyed)
• unwatchResources(["console", "network-request", "source"], onResourceAvailable, onResourceDestroyed)

It is meant to unify the subtle different ways we currently have to:

• start/stop listening to a given type of resources
• notify from the server that a resource is created or destroyed

Each level of abstraction would then have similar API:

• Front.watchFronts
• TargetList.watchTargets
• ResourceAPI.watchResources

Comment 9

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1576624 - Use the Resources API for console messages.

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1576624 - Prototype a Resources API.

This focus on implementing a client side version of the Resources API.
This helps demonstrate that this API can works against existing and old Firefox runtimes, using existing actor APIs.
A following changeset (bug 1620243) will introduce a server-side implementation, which will help listening to resources early.
And will help getting rid of the LegacyImplementation object which is introduced by the next changeset (bug 1620234).

Comment 12

[Phabricator Automation]

Comment on attachment 9131119 [details]
Bug 1576624 - Use the Resources API for console messages.

Revision D65526 was moved to bug 1620234. Setting attachment 9131119 [details] to obsolete.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/237c34042053
Prototype a Resources API. r=jdescottes,nchevobbe

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/237c34042053