157670 - cleanup macprefs.js for chim^H^H^H camino

Status: VERIFIED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[sairuh (rarely reading bugmail)]

summary says it all: we should cleanup macprefs.js for chimera. there are
several font and helper app prefs which simply shouldn't be there.

this might seem like a backend polish issue, but getting rid of unnecessary
prefs is good step in the direction of correctness.

Comment 1

[sairuh (rarely reading bugmail)]

for examples, look at

http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/mac/macprefs.js

other than the gobs of useless font prefs, methinks we'd prolly want to get rid
of the following for chimera usage (do comment if otherwise, however!)

* all editor prefs:
editor.use_html_editor
editor.use_image_editor

* all mail prefs:
mail.notification.sound
mail.close_message_window.on_delete
mail.close_message_window.on_file
mail.server_type_on_restart

* (?)download manager:
browser.downloadmanager.behavior

Comment 2

[Simon Fraser [no longer active]]

See also bug 84271.

Comment 3

[sairuh (rarely reading bugmail)]

here are mimetype prefs that are in today's chimera build (2002.07.16.05). i
guess these don't show up in the lxr link in comment 1 since bnesse cleaned up
the prefs on the trunk (bug 132140), and chimera is still based on the branch.

anyhow, some of these are obviously obsolete (eg, JPEGview for jpeg and gif
--blast from the past!)... not sure which, if all of the rest should be removed.

mime_type("mime.image_gif", "image/gif", "gif", 2, "JPEGView", "JVWR", "GIFf");
mime_type("mime.image_jpeg", "image/jpeg", "jpg,jpeg,jpe", 2, "JPEGView",
"JVWR", "JPEG");
mime_type("mime.image_pict", "image/pict", "pic,pict", 1, "SimpleText", "ttxt",
"PICT");
mime_type("mime.image_tiff", "image/tiff", "tif,tiff", 1, "JPEGView", "JVWR",
"TIFF");
mime_type("mime.image_x_xbitmap", "image/x-xbitmap", "xbm", 2, "Unknown",
"ttxt", "????");

mime_type("mime.audio_basic", "audio/basic", "au,snd", 1, "Sound Machine",
"SNDM", "ULAW");
mime_type("mime.audio_aiff", "audio/aiff", "aiff,aif", 1, "Sound Machine",
"SNDM", "AIFF");
mime_type("mime.audio_x_wav", "audio/x-wav", "wav", 1, "Sound Machine", "SNDM",
"WAVE");

mime_type("mime.video_quicktime", "video/quicktime", "qt,mov", 1, "Simple
Player", "TVOD", "MooV");
mime_type("mime.video_mpeg", "video/mpeg", "mpg,mpeg,mpe", 1, "Sparkle", "mMPG",
"MPEG");
mime_type("mime.video_x_msvideo", "video/x-msvideo", "avi", 1, "AVI to QT
Utility", "AVIC", "????");
mime_type("mime.video_x_qtc", "video/x-qtc", "qtc", 1, "Conferencing Helper
Application", "mtwh", ".qtc");

mime_type("mime.application_mac_binhex40", "application/mac-binhex40", "hqx", 1,
"Stuffit Expander", "SITx", "TEXT");
mime_type("mime.application_x_stuffit", "application/x-stuffit", "sit", 1,
"Stuffit Expander", "SITx", "SITD");
mime_type("mime.application_x_macbinary", "application/x-macbinary", "bin", 1,
"Stuffit Expander", "SITx", "TEXT");
mime_type("mime.application_x_conference", "application/x-conference", "nsc", 1,
"Netscape Conference", "Ncq¹", "TEXT");

mime_type("mime.application_zip", "application/zip", "z,zip", 1, "ZipIt", "ZIP
", "ZIP ");
mime_type("mime.application_gzip", "application/gzip", "gz", 1, "MacGzip",
"Gzip", "Gzip");
mime_type("mime.application_msword", "application/msword", "doc", 0, "MS Word",
"MSWD", "W6BN");
mime_type("mime.application_x_excel", "application/x-excel", "xls", 0, "MS
Excel", "XCEL", "XLS5");

mime_type("mime.application_octet_stream", "application/octet-stream", "exe", 3,
"", "", "");
mime_type("mime.application_postscript", "application/postscript", "ai,eps,ps",
3, "SimpleText", "ttxt", "TEXT");
mime_type("mime.application_rtf", "application/rtf", "rtf", 0, "MS Word",
"MSWD", "TEXT");
mime_type("mime.application_x_compressed", "application/x-compressed", ".Z", 1,
"MacCompress", "LZIV", "ZIVM");
mime_type("mime.application_x_tar", "application/x-tar", "tar", 1, "tar", "TAR
", "TARF");

mime_type("mime.Netscape_Source", "Netscape/Source", "", 2, "SimpleText",
"ttxt", "TEXT");
pref("mime.Netscape_Source.description", "View Source");
mime_type("mime.Netscape_Telnet", "Netscape/Telnet", "", 1, "NCSA Telnet",
"NCSA", "CONF");
mime_type("mime.Netscape_tn3270", "Netscape/tn3270", "", 1, "tn3270", "GFTM",
"GFTS");

mime_type("mime.image_x_cmu_raster", "image/x-cmu-raster", "ras", 3, "Unknown",
"ttxt", "????");
mime_type("mime.image_x_portable_anymap", "image/x-portable-anymap", "pnm", 3,
"Unknown", "ttxt", "????");
mime_type("mime.image_x_portable_bitmap", "image/x-portable-bitmap", "pbm", 3,
"Unknown", "ttxt", "????");
mime_type("mime.image_x_portable_graymap", "image/x-portable-graymap", "pgm", 3,
"Unknown", "ttxt", "????");
mime_type("mime.image_x_rgb", "image/x-rgb", "rgb", 3, "Unknown", "ttxt", "????");
mime_type("mime.image_x_xpixmap", "image/x-xpixmap", "xpm", 2, "Unknown",
"ttxt", "????");

mime_type("mime.SimpleText_ReadOnly", "text/plain", "", 2, "SimpleText", "ttxt",
"ttro");

Comment 4

[Greg K.]

JPEGView a blast from the past? Sparkle!

Comment 5

[Brian Nesse (gone)]

The mime_type stuff is all depricated and unused... that's why it was killed on
the trunk. There are certainly some prefs that can/should go, but if we can wait
on this until we go back to the trunk we will get a lot of cleanup for free.

Comment 6

[Simon Fraser [no longer active]]

Why not just whomp the trunk changes to the branch for now?

The other things that need cleaning up are the font prefs, espcially now that
the user can see all the "xxx.cursive" entries in the UI.

Comment 7

[Brian Nesse (gone)]

Unfortunately, easier said than done. The patch in bug 132140 is a rather large,
invasive patch which removed some things and moved others to the autoconfig
module... Do we care about AutoConfig support in the Chimera branch? I'm
guessing not since we have most of the extensions (including autoconfig) turned
off. I could do a patch that just does the PrefService cleanup/removal portion.

Comment 8

[Josh Aas]

Now that Camino is on the trunk, did the prefs get sufficiently cleaned up? If
so, this bug should be closed.

Comment 9

[saari (gone)]

->sfraser

Comment 10

[Ludovic Hirlimann [:Usul]]

Sfraser Do you think this one should be closed ?

Comment 11

[Simon Fraser [no longer active]]

Yeah. The remaining issue of obsolete font names is covered by other bugs, I think.

Comment 12

[sairuh (rarely reading bugmail)]

macprefs.js seems to be obsolete these days

now use
http://lxr.mozilla.org/mozilla/source/camino/resources/application/all-camino.js