Closed Bug 1576735 Opened 5 years ago Closed 5 years ago

Create Login form cannot be canceled if no logins exist or the applied filter has no matches

Categories

(Firefox :: about:logins, defect, P1)

Product:
Firefox
Component:
about:logins
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [skyline] [passwords:management])

Attachments

(1 file)

Bug 1576735 - Canceling the create login form when no logins are in the list should revert to the previous view. r?MattN
47 bytes, text/x-phabricator-request
Details | Review

STR:
In about:logins, make sure you have 0 saved logins
Click Create New Login
Click cancel

  • nothing happens
    Put some text in the username field
    Click cancel
    Choose Discard on the dialog that appears
  • nothing happens, but the dialog closes
Summary: Create Login form cannot be canceled if no logins exist → Create Login form cannot be canceled if no logins exist or the applied filter has no matches
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P3
Priority: P3 → P1

Since we don't track what login was selected prior to entering the create view, it seemed simplest to reset the filter upon canceling when logins are stored. This has the effect of selecting the first login in the list.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

Comment on attachment 9088309 [details]
Bug 1576735 - Canceling the create login form when no logins are in the list should revert to the previous view. r?MattN

Revision D43544 was moved to bug 1572037. Setting attachment 9088309 [details] to obsolete.

Attachment #9088309 - Attachment is obsolete: true
Attachment #9088309 - Attachment is obsolete: false
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bd14a48e5b8
Canceling the create login form when no logins are in the list should revert to the previous view. r=MattN

https://hg.mozilla.org/mozilla-central/rev/0bd14a48e5b8

Status: ASSIGNED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

I have verified this issue on the latest Nightly 70.0a1 (2019-08-29) (64-bit) on Windows 7 x64, MacOS 10.14 and Ubuntu 18.04.

  • The "Cancel" button is no longer available on "Create New Login" form if 0 logins are saved.
  • The "Login List" is reset and the first saved login is selected after canceling the "Create New Login" form while a filter is applied and no results are returned.
Status: RESOLVED → VERIFIED
status-firefox68: --- → unaffected
status-firefox69: --- → disabled
status-firefox70: fixed → verified
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: