1576828 - Remove pref mailnews.p7m_subparts_external

Status: RESOLVED FIXED

(Thunderbird :: Security, task)

Description

[Kai Engert [:KaiE:]]

We should remove pref mailnews.p7m_subparts_external because setting it to the non-default value exposes the user to security risks.

We should no longer require the pref, because downloading of the attached messages is possible.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: 1576828-v1.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9101913 [details] [diff] [review]
1576828-v1.patch

Review of attachment 9101913 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah as far as I know it's no longer needed.

Comment 3

[Kai Engert [:KaiE:]]

TODO: needs a try build

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29569cac6cec
Remove pref mailnews.p7m_subparts_external and related code/tests. r=mkmelin DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

Sorry, I went ahead and landed this after running the test locally. I don't expect any issues and I'm happy to wear the blame ;-)

Comment 6

[Jorg K (CEST = GMT+2)]

Sigh, I ran the linter to avoid linting issue but it spat the dummy

$ ../mach eslint mailnews/mime/
Exception in thread ProcessReaderStdout:
Traceback (most recent call last):
  File "c:\mozilla-build\python3\lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "c:\mozilla-build\python3\lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "c:\mozilla-source\comm-central\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 1030, in _read_stream
    line = stream.readline()
  File "c:\mozilla-build\python3\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 3272: character maps to <undefined>

✖ 0 problems (0 errors, 0 warnings)

and lied to me since there are problems :-(

Anyway, since I don't have many patches to land, I'll do a real push with the fix in about 6 hours from now. (Edit: Changed my mind)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d026b6b005e
Follow-up: Fix linting issues. rs=white-space-only DONTBUILD

Comment 8

[giulia]

Sorry for the delay.

My patch was related to bug 243833 and the hidden preference used in the code is mailnew.p7m_external

So, i do not see any problem

Comment 9

[giulia]

Comment on attachment 9101913 [details] [diff] [review]
1576828-v1.patch

Review of attachment 9101913 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

My patch was related to bug 243833 and the hidden preference used in the code is mailnew.p7m_external

So, i do not see any problem

Comment 10

[giulia]

Comment on attachment 9101913 [details] [diff] [review]
1576828-v1.patch

Review of attachment 9101913 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

My patch was related to bug 243833 and the hidden preference used in the code is mailnew.p7m_external

So, i do not see any problem

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9101913 [details] [diff] [review]
1576828-v1.patch

+ on behalf of requestee