Closed Bug 1576888 Opened 4 months ago Closed 3 months ago

Stop using px values for #urlbar-contextual-tip's and #urlbar-contextual-tip-button's font sizes

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: dao, Assigned: adw)

References

Details

Attachments

(1 file)

We don't normally use px values for font-sizes, because OSes have different defaults and even offer customizing the default font size. Instead we use em to make text relatively smaller or bigger.

Also note that because the urlbar's font size is different across platforms, the current px values will look more or less inconsistent depending on the OS.

Blocks: 1559495
Priority: -- → P1
Iteration: --- → 71.1 - Sept 2 - 15
Points: --- → 1
Assignee: nobody → adw
Status: NEW → ASSIGNED

Make #urlbar-contextual-tip inherit its font size so that it's the same as the size used for other results. Set #urlbar-contextual-tip-button's font size to 1em to override the smaller <button> default font size.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/982bb9015f79
Stop using px values for #urlbar-contextual-tip's and #urlbar-contextual-tip-button's font sizes. r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9091220 [details]
Bug 1576888 - Stop using px values for #urlbar-contextual-tip's and #urlbar-contextual-tip-button's font sizes.

Beta/Release Uplift Approval Request

  • User impact if declined: We may want to run an experiment on 70 that would use this patch.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1576889 must be uplifted first
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a trivial CSS patch. This UI isn't even visible in Firefox by default. It would only be shown in an experiment.
  • String changes made/needed: None
Attachment #9091220 - Flags: approval-mozilla-beta?

Comment on attachment 9091220 [details]
Bug 1576888 - Stop using px values for #urlbar-contextual-tip's and #urlbar-contextual-tip-button's font sizes.

CSS change to support an experiment on 70. OK for uplift to beta 7.

Attachment #9091220 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.