1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

Judging by just looking at the code, this is probably not RTL-friendly: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/themes/shared/urlbar-autocomplete.inc.css#67
You normally want to use padding-inline-end instead of padding-right.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds.

The padding-right is the oversight afaict. This patch is based on D45125.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09bbd4844121
Ensure Quantum Bar Contextual Tip looks correct in RTL builds. r=dao

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/09bbd4844121

Comment 4

[Julien Cristau [:jcristau]]

Should this be uplifted to beta70?

Comment 5

[Drew Willcoxon :adw]

I'm not sure we're planning on running on 70 the experiment that would use this -- I don't think so -- but it would be nice to have the option, and it's a trivial patch, so I'll request. Bug 1576888 too.

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9091222 [details]
Bug 1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds.

Beta/Release Uplift Approval Request

• User impact if declined: We may want to run an experiment on 70 that would use this patch.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a trivial one-line CSS patch. This UI isn't even visible in Firefox by default. It would only be shown in an experiment.
• String changes made/needed: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091222 [details]
Bug 1576889 - Ensure Quantum Bar Contextual Tip looks correct in RTL builds.

CSS fix for RTL, fine for uplift for beta 7.

Comment 8

[Tim Nguyen :ntim]

https://hg.mozilla.org/releases/mozilla-beta/rev/73b1e46376d39da424761ed3c274f5e05ce91b0e