Closed Bug 1576915 Opened 3 months ago Closed 15 days ago

Port PictureInPictureChild and PictureInPictureToggleChild message manager actors to JSWindowActors

Categories

(Toolkit :: Video/Audio Controls, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: mconley, Assigned: bayyatej.dev, Mentored)

References

(Blocks 4 open bugs)

Details

Attachments

(1 file, 3 obsolete files)

Priority: -- → P3
Assignee: nobody → bayyatej.dev
Status: NEW → ASSIGNED
Mentor: gijskruitbosch+bugs, mconley

Hey nika,

So this is the bug where Teja is attempting to port PictureInPictureChild to JSWindowActors. Like I mentioned yesterday, part of the issue seems to be the WindowGlobalParent getting swapped out early in the lifetime of the remote <browser> that hosts the cloned video, because it's getting explicitly navigated to about:blank.

You mentioned yesterday that we can avoid that extra about:blank load by setting nodefaultsrc to true on the <browser>, and not actually navigating it anywhere - and you're right, this means that the first WindowGlobalParent we get from it doesn't change, and we can reliably send messages through to the child-side. Great!

The problem now seems to be that this initial about:blank that's loaded in the remote browser doesn't seem to want to display anything. The inner window itself reports having appropriate dimensions, but the underlying document element and document body resolve to having 0 width and 0 height, so nothing is displayed.

Any ideas what we can do about that? Note that by loading another document in that frame, we do get that document showing up (but then we get the problem of the swapped out WindowGlobalParent that we started with).

Flags: needinfo?(nika)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

The problem now seems to be that this initial about:blank that's loaded in the remote browser doesn't seem to want to display anything. The inner window itself reports having appropriate dimensions, but the underlying document element and document body resolve to having 0 width and 0 height, so nothing is displayed.

Any ideas what we can do about that? Note that by loading another document in that frame, we do get that document showing up (but then we get the problem of the swapped out WindowGlobalParent that we started with).

Apologies for the driveby, but this sounds suspiciously similar to what kmag was saying in https://bugzilla.mozilla.org/show_bug.cgi?id=1582788#c1 .

Attachment #9094236 - Attachment description: Bug 1576915 Partial Port of Picture in Picture to JSWindowActors → Bug 1576915 Partial Port of Picture in Picture to JSWindowActors using async player workaround
Attachment #9098403 - Attachment description: Bug 1576915 Port PiPToggle to JSWindowActors → Bug 1576915 Partially port PiPToggle to JSWindowActors
Attachment #9098403 - Attachment description: Bug 1576915 Partially port PiPToggle to JSWindowActors → Bug 1576915 Port PiPToggle to JSWindowActors
Attachment #9096932 - Attachment is obsolete: true
Attachment #9098403 - Attachment is obsolete: true
Attachment #9094236 - Attachment is obsolete: true
Summary: Port PictureInPictureChild and PictureInPictureToggleChild message manager actors to JSWindowActor to make it Fission-compatible → Port PictureInPictureChild and PictureInPictureToggleChild message manager actors to JSWindowActors
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2012ad5d5af4
Port of Picture in Picture to JSWindowActors r=mconley
Status: ASSIGNED → RESOLVED
Closed: 15 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: needinfo?(nika)

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.