1576935 - Fxa toolbar menu styling inconsistencies with `Sync Tabs` and `Send Tab to Device`

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task, P3)

Description

[Vijay Budhram]

Attachment: syncedtabs.png

While working on https://bugzilla.mozilla.org/show_bug.cgi?id=1573170, :rfeeley noticed that the two panels don't match each other very well and have inconsistent styles. I have attached the current state of the panels.

The panels should be styled as close as possible to https://mozilla.invisionapp.com/share/C9TF95Q8GJM#/378655927_Skyline_FxA_Toolbar.

Comment 1

[Vijay Budhram]

Attachment: sendtabtodevice.png

Comment 2

[Tanner Davies]

Could I take this bug?

Comment 3

[Tanner Davies]

(In reply to Tanner Davies from comment #2)

Could I take this bug?

By "bug" I mean task. haha

Comment 4

[Tanner Davies]

The "Synced Tabs" panel looks cleaner to me than the "Send Tab to Device" panel. I think the formatting of the latter should be adjusted to match the formatting of the former.

Comment 5

[Tanner Davies]

(In reply to Tanner Davies from comment #4)

The "Synced Tabs" panel looks cleaner to me than the "Send Tab to Device" panel. I think the formatting of the latter should be adjusted to match the formatting of the former.

Excuse me. I didn't see the statement on how the style should be.

Comment 6

[Tanner Davies]

Attachment: Bug 1576935 - Fix formatting of "Synced Tabs" panel to match that of the "Send Tab to Device" panel r=markh

Depends on D56278

Comment 7

[Alex Davis [:adavis]]

Attachment: Screenshot of Invision File

I'll try to get UX to add more details to this bug. At first glance, the buttons and fonts don't match.

Based on the linked Invision document, I'm guessing that we need to align the style of Synced tabs to that of the Send Tab menu.

Attached is a screenshot from the Invision document in case it is not visible publicly.

Comment 8

[Tanner Davies]

My patch should have aligned the styles to match what is in the Invision doc

Comment 9

[Ryan Feeley [:rfeeley]]

Thanks Alex for referring to the latest design, always the best place to check, though I can appreciate that finding an Invision link is not always easy.

I would definitely like us to match the styling in the Invision, though I'm hoping at a higher level that Firefox can align all of their single-CTA panels.

Hopefully what we have there will do, but I will NEEDINFO shorlander who probably already has an answer for us.

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Tanner, could you please upload screenshots for the panel(s?) changed by your patch?

Comment 11

[Tanner Davies]

Sure thing!

Comment 12

[Tanner Davies]

Attachment: image.png

The synced tabs panel

Comment 13

[Tanner Davies]

Attachment: image.png

The "Send Tab to Device" panel

Comment 14

[Ryan Feeley [:rfeeley]]

Much improved, thanks Tanner!

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tanner.e.davies, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 17

[Tanner Davies]

Mark, is there something we are waiting on for this bug fix to be landed?

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e832419ad629
Fix formatting of "Synced Tabs" panel to match that of the "Send Tab to Device" panel r=vbudhram

Comment 19

[Mark Hammond [:markh] [:mhammond]]

Good bot - this would have slipped otherwise! Someone just needed to press the button, which I did

Comment 20

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e832419ad629