1577289 - View Message Source + Save Page As gives: ReferenceError: can't access lexical declaration `SAVEMODE_FILEONLY' before initialization contentAreaUtils.js:1359:5

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

ReferenceError: can't access lexical declaration `SAVEMODE_FILEONLY' before initialization contentAreaUtils.js:1359:5
GetSaveModeForContentType chrome://global/content/contentAreaUtils.js:1359
internalSave chrome://global/content/contentAreaUtils.js:466
ViewSourceSavePage chrome://messenger/content/viewSource.js:762
oncommand chrome://messenger/content/viewSource.xul:1

Not working in TB 68 :-(

Comment 1

[:aceman]

Attachment: 1577289.patch

This fixes the uninitialized constant.
Now the saving fails with:

Security Error: Content at view-source:mailbox:///xxx/Mail/yyy/Sent?number=1 may not load or link to mailbox:///xxx/Mail/yyy/Sent?number=1.

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPersist.savePrivacyAwareURI]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/contentAreaUtils.js :: internalPersist :: line 666" data: no] contentAreaUtils.js:666:13

Comment 2

[Jorg K (CEST = GMT+2)]

Do we pass a principal at any stage? Then use a system principal. Surely the two schemes don't match: view-source:mailbox and mailbox:

Comment 3

[Jorg K (CEST = GMT+2)]

We've seen this error here: bug 1564094 comment #0.

Comment 4

[:aceman]

Attachment: 1577289.patch v2

Good idea, passing system principal helped.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9088856 [details] [diff] [review]
1577289.patch v2

Thanks. Great you found the optional principal argument.

It works now although the function isn't totally useful, better so just save the message.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ecec2c37acf
reorder imports in viewSource.xul to properly initialize SAVEMODE_FILEONLY in contentAreaUtils.js and save the message source using system principal. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/c5df81b5963a8315b3d3f6ffcba172cfb1e7eae3