Padding above and below favicon in PersonalToolbar (bookmarks toolbar) does not match when toolbar is below nav bar
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: yoasif, Unassigned)
References
Details
Attachments
(1 file)
|
285.14 KB,
image/png
|
Details |
ySge95n.png
As reported on reddit: https://www.reddit.com/r/firefox/comments/ctca6q/macos_nightly_coreanimation_has_been_enabled_by/ey9qooc/
See screenshot.
"There are 7px between the address bar and where the favicon starts. Under the icon/text, there's only 4px."
User expects to see 7px both above and below the favicon.
When I looked at the browser source, I found this comment:
/* The bookmarks toolbar is smaller than the other toolbars, so we
- need to override the badge position to not be cut off. */
So it seems like the bookmarks toolbar is small on purpose -- making the spacing match above and below the favicon would necessitate that the toolbar grow in size.
|
Reporter | |
Comment 1•5 years ago
|
||
Dão, I'd like to understand if there is a reason that the bookmarks toolbar needs to be small, or whether you would accept a patch to make the spacing above and below the favicon in the bookmarks toolbar match. This would make the bookmarks toolbar vertically larger, but it could be a nice polish item, since other browsers seem to have matching metrics in this area.
Thanks!
|
||
Comment 2•5 years ago
|
||
The toolbar is intentionally small to we don't waste vertical space. Also, the screenshot you provided is somewhat misleading because the urlbar doesn't fill the navigation toolbar's full height, i.e. it has extra margin around itself. The toolbar border is somewhere within the red bar.
|
|
Reporter | |
Comment 3•5 years ago
|
||
Dão, does this deserve another look given the discussion in bug 1561904?
Just looking at this as a fit and finish item as discussed previously.
Description
•