1577437 - Safe mode "Disable all add-ons" checkbox + "Make Changes and Restart" button doesn't work

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[andysem]

Attachment: thunderbird_safe_mode.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. In "Help -> Troubleshooting Information", click "Restart with addons disabled".
2. Upon restart, Thunderbird Safe Mode window appears. There, check the "Disable all addons" checkbox.
3. Try clicking on the "Make Changes and Restart" button.

Actual results:

The button, although not greyed out, cannot be pressed. Nothing happens when I click on it.

Expected results:

The button should work.

Comment 1

[Benjamin Flanagin]

Confirmed.

Comment 2

[Wayne Mery (:wsmwk)]

This is a little concerning that a primary debug tool is broken.

Benjamin, are you also able to reproduce this on Windows? (I was not)

Comment 3

[Eckard Berberich]

I confirm the issue for TB 68.0.
But the same issue already is present in TB60.8.0.

Comment 4

[WaltS48 [:walts48]]

I tested this in Thunderbird 69.0b4 on Ubuntu 18.04.3 LTS.
Selected "Toolbars and Controls" instead of "Disable all add-ons" and the "Make Changes and Restart" button worked for me.
Restored me backed up profile and got all my toolbar and control settings back.

Comment 5

[Jorg K (CEST = GMT+2)]

Not working in TB 60 either. Comment #3 and comment #4 are correct.

Comment 6

[Benjamin Flanagin]

I just tried this on Windows using Thunderbird 69.0b4. The interface works as expected.

Comment 7

[Jorg K (CEST = GMT+2)]

It doesn't.

STR:
Help > Restart with add-ons disabled
Restart
Click" Disable all add-ons"
Click button "Make Changes and Restart

Nothing happens.

Comment 8

[Benjamin Flanagin]

Ah, I clicked the wrong button, need to slow down and be more observant.

Comment 9

[WaltS48 [:walts48]]

I see the same using TB 70.0a1.

Comment 10

[Wayne Mery (:wsmwk)]

Nothing in error console?

Comment 11

[andysem]

The only console output I see is:

WebGL(0x7f234cdba000)::ForceLoseContext
WebGL(0x7f234cdbf800)::ForceLoseContext

If there is some other kind of console, please tell how to capture its output.

Comment 12

[Wayne Mery (:wsmwk)]

andysem,
Still see this in a current beta?

FWIW I found no other reports of this. https://mzl.la/3amOGpV

Comment 13

[Eckard Berberich]

I can still reproduce this bug in TB 76.0b1.

Comment 14

[WaltS48 [:walts48]]

(In reply to Eckard Berberich from comment #13)

I can still reproduce this bug in TB 76.0b1.

So can I using 76.0b1 and 77.0a1 on Linux.

Comment 15

[Wayne Mery (:wsmwk)]

NI Magnus to assign dev

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: bug1577437_safemode.patch

AddonManager.getAllAddons doesn't take a callback, so nothing happens...

Comment 17

[Paul Morris [:pmorris]]

Comment on attachment 9153137 [details] [diff] [review]
bug1577437_safemode.patch

Review of attachment 9153137 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  I've tested with and without the patch and found that it fixes the problem. (Tested on Linux with current trunk build.)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5cefc4c79165
fix "Make Changes and Reset" - AddonManager.getAllAddons doesn't use a callback anymore. r=pmorris