1577443 - Remove cmd_checkLinks that is unused

Status: RESOLVED FIXED

(SeaMonkey :: Composer, enhancement)

Description

[Makoto Kato [:m_kato]]

https://searchfox.org/comm-central/search?q=cmd_checkLinks&path=

cmd_checkLinks seems not to use in Thunderbird and SeaMonkey. Although debugQAEditorOverlay.xul has menu for this command, this is debugging tools.

This is only user of nsIHTMLEditor.getLinkedObjects that is unused by Firefox. So I hope that cmd_checkLinks is removed since it is unused since I would like to remove nsIHTMLEditor.getLinkedObjects from Gecko.

Comment 1

[Makoto Kato [:m_kato]]

Ian, is cmd_checkLinks still needed? This seems to be used on debugQA extension only. Although this command uses nsIHTMLEditor.getLinkedObjects method, it isn't used in Firefox and I would like to remove this method from Gecko.

Comment 2

[Frank-Rainer Grahl (:frg)]

I think it can be removed. It is a debugging help for Composer but seems to do nothing.

Comment 3

[Ian Neal]

As cmd_checkLinks also relies on URIChecker which was removed in Bug 1222829 (in Gecko 45 around 4 years ago and spotted by me a year later), I'm fairly sure that nsIHTMLEditor.getLinkedObjects method can be removed.

Comment 4

[Ian Neal]

Attachment: Remove checkLinks for cc

Patch for comm-central that doesn't remove l10n

Comment 5

[Ian Neal]

Attachment: Remove checkLinks for 2.57

Patch for SM 2.57, does have l10n string removal

Comment 6

[Ian Neal]

Attachment: Remove checkLinks for 2.53

[Approval Request Comment]
Regression caused by (bug #): 1222829
User impact if declined: None, doesn't work anyway
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: One string removal and one dtd file removal

Comment 7

[Ian Neal]

Attachment: Remove checkLinks for cc v1.1

Include l10n removals as requested

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9089553 [details] [diff] [review]
Remove checkLinks for cc v1.1

And away it goes

Comment 9

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9089463 [details] [diff] [review]
Remove checkLinks for 2.53

r/a=me

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9089460 [details] [diff] [review]
Remove checkLinks for 2.57

r/a=me.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/429123f68201
Remove cmd_checkLinks that is unused. r=frg DONTBUILD

Comment 12

[Frank-Rainer Grahl (:frg)]

Fixed. Pushed with DONT BUILD all suite code (composer).
https://hg.mozilla.org/releases/comm-esr60/rev/c773e2fef6cab3d26aaf46c31e6789cfd6f75a22

Comment 14

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fa1a30a989cd18772d51f07c12045133ca15140b