1577587 - minimize to dock doesn't work

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[fiveNinePlusR]

Double clicking on the titlebar in mac os doesn't minimize firefox to the dock with the "Double click a window's titlebar to minimize the dock" preference enabled.

Comment 1

[Dão Gottwald [:dao]]

I suppose this never worked ever since we put tabs in the title bar? Or is this a recent regression?

Comment 2

[fiveNinePlusR]

it's worked for a long time only recently breaking in the past few days. there might be a relevant about:config item that shows the titlebar though that some people don't have set.

Comment 3

[Dão Gottwald [:dao]]

What version of Firefox are you using?

Comment 4

[fiveNinePlusR]

It for sure was broken in 70.0a1 (2019-08-27) (64-bit) and is still broken in 70.0a1 (2019-08-30) (64-bit)

Comment 5

[Markus Stange [:mstange]]

I found the problem in the code, but it's not clear to me how this could have broken recently. It should have been broken ever since macOS 10.11.

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1577587 - Check the correct preference in -[ChildView shouldMinimizeOnTitlebarDoubleClick] on 10.11 and up. r=spohl

I got these names from https://forums.developer.apple.com/thread/30166 .

Comment 7

[fiveNinePlusR]

I do use this feature fairly often and I'm positive I've used it since 10.11 rolled around. perhaps it's some other cause that changed that preference value from working? I'm on 10.13.6 fwiw and have usually updated close to the release of each OS. (except 10.14+ because hardware incompatibilities)

Comment 8

[Stephen A Pohl [:spohl]]

n-i just in case my phabricator r+ was missed. Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f478b82706bd
Check the correct preference in -[ChildView shouldMinimizeOnTitlebarDoubleClick] on 10.11 and up. r=spohl

Comment 10

[Stephen A Pohl [:spohl]]

Actually, I went ahead and landed this.

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f478b82706bd

Comment 12

[Markus Stange [:mstange]]

Thanks for landing it!

Comment 13

[fiveNinePlusR]

on latest nightly and it looks like this patch is included but the issue still remains. can someone else verify this?

Comment 14

[Markus Stange [:mstange]]

(In reply to fiveNinePlusR from comment #13)

on latest nightly and it looks like this patch is included but the issue still remains. can someone else verify this?

Oh, that is unfortunate. I've filed a new bug about this (bug 1581433) so that we can keep this one closed, because we try to have one landing per bug and the patch definitely fixed the problem on my 10.12 machine.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Was this something we intended to uplift to Beta for Fx70? RC week is next week.

Comment 16

[Markus Stange [:mstange]]

Yes, let's uplift. We'll also want to uplift bug 1581433 but I've only just written the patch for that one.

Comment 17

[Markus Stange [:mstange]]

Comment on attachment 9089477 [details]
Bug 1577587 - Check the correct preference in -[ChildView shouldMinimizeOnTitlebarDoubleClick] on 10.11 and up. r=spohl

Beta/Release Uplift Approval Request

• User impact if declined: Double clicking on toolbars doesn't minimize the window despite the system setting.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just adds a check to another system preference. I've tested it on multiple macOS versions.
• String changes made/needed:

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089477 [details]
Bug 1577587 - Check the correct preference in -[ChildView shouldMinimizeOnTitlebarDoubleClick] on 10.11 and up. r=spohl

Fix for new regression in 70, OK for beta 14 uplift.

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/62883ff399ad

Comment 20

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Beta build: 20191007220302
Verified - fixed on latest Beta 70.0b14 (Build id: 20191010142853) and latest Nightly 71.0a1 (Build id: 20191010214019) on Mac OS 10.14 and Mac OS 10.15