1577708 - Very low on-hover contrast in dark theme Change Search Settings button

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot from 2019-08-30 10-39-41.png

Affected versions

• 70.0b2, 70.0a1 (2019-08-29)

Affected platforms

• Ubuntu 16.04

Steps to reproduce

1. Launch Firefox swap to Dark Theme and enable the search bar;
2. Click inside the Search Bar and type any text;
3. Hover over the Change Search Settings button;

Expected result

• Buttons are properly displayed;

Actual result

• the default state of the background_color for the button is the on_hover one;
• the hover effect makes it so the text is not readable;

Regression range

• Pushlog URL
• Potential regressor: bug 1561894;

Additional notes

• attached screenshot with the issue;
• 68, 69 builds are not affected;

Comment 1

[Dão Gottwald [:dao]]

I assume it was a mistake that your marked 69 as affected.

Harry, this is probably your regression. Can you take a look?

Comment 2

[Cristian Fogel [:cfogel]]

Thank you for the correction, indeed was force of habit.
Re-confirmed with 69.0 and 69.b016 and they are not affected.
Managed to get the regression range as well, updating the initial post with the results.

Comment 3

[Harry Twyford]

Attachment: Bug 1577708 - Increase contrast on search settings button. r?dao

Comment 4

[Harry Twyford]

While this problem is worst on Linux, I'm expanding the scope of this bug since contrast is low on all platforms. The attached patch affects all platforms as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c166af1c637e
Increase contrast on search settings button. r=dao

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c166af1c637e

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request beta uplift? It would be nice to not ship this regression.

Comment 8

[Harry Twyford]

Comment on attachment 9089946 [details]
Bug 1577708 - Increase contrast on search settings button. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Low contrast on a UI element. Contrast issues are bad enough that the element is sometimes invisible on Linux.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single-line CSS change on a fairly low-traffic component of the browser (the standalone search bar).
• String changes made/needed:

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089946 [details]
Bug 1577708 - Increase contrast on search settings button. r?dao

CSS fix, helps a11y, let's uplift.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/585345b7a19f

Comment 11

[Peter Magyari (Desktop QA)]

I've managed to reproduce this issue on Firefox Nightly 70.0a1 (2019-08-29) and verified that it has been fixed on Nightly 71.0a1 (2019-9-10)
I'll be back to verify it on Beta 70b5 asap.

Comment 12

[Peter Magyari (Desktop QA)]

I've also verified the fix on Firefox Beta 70.0b5