1561894 - Implement simplified one-off search button design

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Dão Gottwald [:dao]]

Invision spec: https://mozilla.invisionapp.com/share/DNSDVW5E8QK#/screens/367251846_Photon_Design_Update

Putting the "This time, search with:" string on the same line as the buttons might create problems with locales using a longer string, and there are edge cases when a user has lots of engines or a narrow urlbar. Need to clarify that with UX.

Comment 2

[Verdi [:verdi] Best to slack me]

Attachment: one-off-overflow.png

Here's how the overflow should work. Basically, the search icons start 24px after the string and then they wrap 8px below with the icons lining up vertically. Let me know if you have questions.

Comment 3

[Harry Twyford]

Attachment: Bug 1561894 - Implement simplified one-off search button design. r?dao

Comment 4

[Dão Gottwald [:dao]]

I thought we were going to do this behind a pref for the experiment. Can you please confirm with verdi that we can implement this without a pref, immediately replacing the current desing?

Comment 5

[Harry Twyford]

Verdi and mikedeboer confirm that we're just going to replace immediately.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7af558091d18
Implement simplified one-off search button design. r=dao

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7af558091d18

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Hello,
Michael, we encountered this behavior on beta 5. Based on the e-mail thread "Firefox 69-70/71 url bar inconsistency", we understood that this experiment should be hidden behind a pref code, did something change?
Thank you!

Comment 9

[Dão Gottwald [:dao]]

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #8)

Hello,
Michael, we encountered this behavior on beta 5. Based on the e-mail thread "Firefox 69-70/71 url bar inconsistency", we understood that this experiment should be hidden behind a pref code, did something change?
Thank you!

This was already resolved in said e-mail thread. This is going to ship in 70 without a pref.