Closed Bug 1561894 Opened 3 months ago Closed Last month

Implement simplified one-off search button design

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.3 - Aug 5 - 18
Tracking Status
firefox70 --- fixed

People

(Reporter: dao, Assigned: harry)

References

(Blocks 1 open bug, Regressed 3 open bugs)

Details

Attachments

(2 files)

Invision spec: https://mozilla.invisionapp.com/share/DNSDVW5E8QK#/screens/367251846_Photon_Design_Update

Putting the "This time, search with:" string on the same line as the buttons might create problems with locales using a longer string, and there are edge cases when a user has lots of engines or a narrow urlbar. Need to clarify that with UX.

Points: --- → 3
Duplicate of this bug: 1389573
Attached image one-off-overflow.png

Here's how the overflow should work. Basically, the search icons start 24px after the string and then they wrap 8px below with the icons lining up vertically. Let me know if you have questions.

Assignee: nobody → htwyford
Iteration: --- → 70.2 - Jul 22 - Aug 4
Keywords: blocked-ux

I thought we were going to do this behind a pref for the experiment. Can you please confirm with verdi that we can implement this without a pref, immediately replacing the current desing?

Flags: needinfo?(htwyford)

Verdi and mikedeboer confirm that we're just going to replace immediately.

Flags: needinfo?(htwyford)
Blocks: 1421238
Status: NEW → ASSIGNED
Iteration: 70.2 - Jul 22 - Aug 4 → 70.3 - Aug 5 - 18
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7af558091d18
Implement simplified one-off search button design. r=dao
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Blocks: 1527257
Regressions: 1577708
Blocks: 1579078
Regressions: 1579767

Hello,
Michael, we encountered this behavior on beta 5. Based on the e-mail thread "Firefox 69-70/71 url bar inconsistency", we understood that this experiment should be hidden behind a pref code, did something change?
Thank you!

Flags: needinfo?(mverdi)

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #8)

Hello,
Michael, we encountered this behavior on beta 5. Based on the e-mail thread "Firefox 69-70/71 url bar inconsistency", we understood that this experiment should be hidden behind a pref code, did something change?
Thank you!

This was already resolved in said e-mail thread. This is going to ship in 70 without a pref.

Flags: needinfo?(mverdi)
Regressions: 1577183
Regressions: 1581096
Regressions: 1577740
Regressions: 1581753
You need to log in before you can comment on or make changes to this bug.