1577716 - The "(no username)" placeholder is wrongly displayed when creating a new login

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: creating new login.png

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Open the latest Nightly browser and navigate to "about:logins" page.
2. Click the "Create New Login" button.
3. Observe the "Username" field.

[Expected results]:

• The "e.g., janedoe" placeholder is displayed.
  OR
• The old "[e-mail]" placeholder is displayed.

[Actual results]:

• The "(no username)" placeholder is displayed.

[Notes]:

• Based on the mock-ups the "e.g., janedoe" placeholder should be displayed when creating new logins.
• Attached a screenshot with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1577716 - Remove the placeholder when editing a login. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a968a6cd8ed
Remove the placeholder when editing a login. r=MattN,fluent-reviewers,flod

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a968a6cd8ed

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (2019-09-06) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 16.04.
- No placeholder is displayed on the "Username" field when creating/editing a login.

Comment 5

[Julien Cristau [:jcristau]]

Does this need uplift to beta70?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Yes, it needs uplift. I am working with David Durst and MattN to coordinate a single uplift of multiple patches to make sure they land in order and are merged properly.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/31b64d9a0e7b

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b8 (Build ID: 20190919164641) build on Windows 10 x64, Mac 10.14 and Ubuntu 18.04 x64..

• No placeholder is displayed on the "Username" field when creating/editing a login.