1577890 - Clean-up all fennec related code for media control

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Alastor Wu [:alwu]]

As Fennec is going to be deprecated and Fennec is no longer using the latest Nightly, it uses ESR68 related verisions and only accepts security issues to be uplifted.

Therefore, basically, we can remove all Fennec related media control codes in MediaElement and AudioChannelService.

Comment 1

[Alastor Wu [:alwu]]

Now I'm working on this, and I will target this on the next release cycle.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part1 : remove 'media-playback' notification.

media-playback is a notification which we used for Fennec to indicate media has started playing and we should show the virtual controller interface. As it's not being used by anyone since we deprecate Fennec, we can remove all related code.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part2 : remove 'media-playback-resumed' notification.

media-playback-resumed was a notification we used on Fennec to indicate media playback state changes and we should update the UI button on the virtual control interface. As it's not being used by anyone since we deprecate Fennec, we can remove all related code.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part3 : remove media control related code in AndroidBridge.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part4 : remove media control Android chrome test.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part5 : remove tests for checking suspend states.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part6 : remove browser's methods which were used for android media control.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part7 : remove 'computedSuspended' which is a testing-only attribute.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part8 : remove fennec media control related logic from HTMLMediaElement

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part9 : remove unused suspend types.

Comment 11

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part10 : remove unused function 'ShouldBlockMedia()'.

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1577890 - part11 : remove 'mediaSuspend' from nsIDOMWindowUtils.

After removing Fennec-specific media control and audio focus related code, now no one is using mediaSuspend attribute, so we can remove it as well.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b930c378261f
part1 : remove 'media-playback' notification. r=baku
https://hg.mozilla.org/integration/autoland/rev/5773999b5369
part2 : remove 'media-playback-resumed' notification. r=baku
https://hg.mozilla.org/integration/autoland/rev/7ec5367d5333
part3 : remove media control related code in AndroidBridge. r=snorp
https://hg.mozilla.org/integration/autoland/rev/d40249d08f6d
part4 : remove media control Android chrome test. r=snorp
https://hg.mozilla.org/integration/autoland/rev/18d03fa6afc8
part5 : remove tests for checking suspend states. r=baku
https://hg.mozilla.org/integration/autoland/rev/bce6163912b5
part6 : remove browser's methods which were used for android media control. r=baku
https://hg.mozilla.org/integration/autoland/rev/df73edd2575f
part7 : remove 'computedSuspended' which is a testing-only attribute. r=baku
https://hg.mozilla.org/integration/autoland/rev/3d10b03cd269
part8 : remove fennec media control related logic from HTMLMediaElement r=baku
https://hg.mozilla.org/integration/autoland/rev/769dc257c2ba
part9 : remove unused suspend types. r=baku
https://hg.mozilla.org/integration/autoland/rev/991725a20664
part10 : remove unused function 'ShouldBlockMedia()'. r=baku
https://hg.mozilla.org/integration/autoland/rev/b1cdc8118638
part11 : remove 'mediaSuspend' from nsIDOMWindowUtils. r=baku

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b930c378261f
https://hg.mozilla.org/mozilla-central/rev/5773999b5369
https://hg.mozilla.org/mozilla-central/rev/7ec5367d5333
https://hg.mozilla.org/mozilla-central/rev/d40249d08f6d
https://hg.mozilla.org/mozilla-central/rev/18d03fa6afc8
https://hg.mozilla.org/mozilla-central/rev/bce6163912b5
https://hg.mozilla.org/mozilla-central/rev/df73edd2575f
https://hg.mozilla.org/mozilla-central/rev/3d10b03cd269
https://hg.mozilla.org/mozilla-central/rev/769dc257c2ba
https://hg.mozilla.org/mozilla-central/rev/991725a20664
https://hg.mozilla.org/mozilla-central/rev/b1cdc8118638