Closed Bug 1572869 (media-control) Opened 2 years ago Closed 2 months ago

[meta] Media control tracking bug [*** see URL link for more details ***]

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: alwu, Assigned: alwu)

References

(Depends on 20 open bugs, )

Details

(Keywords: feature-testing-meta, meta)

This is a meta bug to track all media control related issues and there are some different possible features which we could implement under this topic.

To see more detailed information, please check our public documentation [1]

[1] https://bit.ly/3aedNfn

Depends on: 1575995
Depends on: 1577367
Depends on: 1577890
Depends on: 1578615
Depends on: 1578945
Depends on: 1579588
Depends on: 1584029
Depends on: 1584030
Duplicate of this bug: 448910
Depends on: 1353652
Depends on: 1251795
Depends on: 1584501

Speaking of 448910, there is one take away though:

  1. We might need a bug to track control of regular <video> and <audio> elements
  2. We have to think about in-app-focus. What happens if I open two videos in different tabs vs different windows etc.
  3. We might need a bug to track combining all the bugs, wiering up the APIs

(In reply to Marc Streckfuß from comment #3)

Speaking of 448910, there is one take away though:

  1. We might need a bug to track control of regular <video> and <audio> elements

All those things are based on controlling <video> and <audio> tags, so I don't understand why we need another bug to track them.
Eg. In bug1575995, we are able to control those tags via mac play/pause key.

  1. We have to think about in-app-focus. What happens if I open two videos in different tabs vs different windows etc.

Audio competing between tabs has been implemented in bug1565689. On Android, we have an android component to handle audio focus between apps.

  1. We might need a bug to track combining all the bugs, wiering up the APIs

That's why we use this bug to track all related implementations.

Depends on: 1590579
Depends on: 1591230
Depends on: 1591288
No longer depends on: webext-commands-global
See Also: → 1584542
Depends on: 1591608
Depends on: 1591620
Depends on: 1592037
Depends on: 1592151
Depends on: 1592454
Depends on: 1592461
Depends on: 1593131
Depends on: 1593826
Depends on: 1598968
Depends on: 1599591
Depends on: 1599938

One thing I have to investigate is PlayPause() vs. dedicated Play() and Pause().
Under MPRIS I had the "bug", that when pausing the video manually, I had to press my media button twice, as it's state was on "still playing".

I think the major takeaway here is, that we need to propagate such "MediaStateChangeEvents" to the native backends, so the OS knows that the video has been paused (which is also important for UI/UX).
Is that related to the Metadata, i.e.e could this be done in one pass?

Depends on: 1601144
Depends on: 1601379
Depends on: 1601508
Depends on: 1601510
Depends on: 1602336
Depends on: 1602617

(In reply to Marc Streckfuß [:MeFisto94] from comment #5)

I think the major takeaway here is, that we need to propagate such "MediaStateChangeEvents" to the native backends, so the OS knows that the video has been paused (which is also important for UI/UX).
Is that related to the Metadata, i.e.e could this be done in one pass?

Yes, I've also been thinking about the same thing, we should have a event to notify when media controller playing state change or metadata change.

Depends on: 1603527
Depends on: 1603544
Depends on: 1603878
Depends on: 1604653
Depends on: 1604691
Depends on: 1604962
Depends on: 1605769
Depends on: 1606588
Depends on: 1606782

This will annoy plenty of Mac users that use iTunes/Music/Spotify. A workaround to lock your media keys to your preferred music app is https://github.com/milgra/macmediakeyforwarder.

Is there a chance of adding a pref or an toggle in Preferences for this behavior?

Depends on: 1609452
Depends on: 1610723
Depends on: 1611021
Depends on: 1611031
Depends on: 1611235
Depends on: 1611272
Depends on: 1611328
Depends on: 1611332
Depends on: 1613600
Depends on: 1615112
Depends on: 1615270
Depends on: 1615375
Depends on: 1615665
Depends on: 1616800
Depends on: 1617033
Depends on: 1617405
Depends on: 1617866
Depends on: 1619104
Depends on: 1620113
Depends on: 1620340
Depends on: 1620470
Depends on: 1582508
Depends on: 1621166
Depends on: 1619861
Depends on: 1623202
Depends on: 1623486
Depends on: 1623715
Depends on: 1623971
Depends on: 1625580
Depends on: 1627818
Depends on: 1627999
Depends on: 1631075
Depends on: 1631087
Depends on: 1631095
Depends on: 1631608
Depends on: 1632301
Depends on: 1632317
Depends on: 1633565
Depends on: 1633642
Depends on: 1633830
Depends on: 1633904
Depends on: 1634190
Depends on: 1634192
Depends on: 1634494
Depends on: 1635209
Depends on: 1637466
Depends on: 1640339
Depends on: 1640998
Depends on: 1642711
Depends on: 1642715
Depends on: 1642729
Depends on: 1642829
Depends on: 1643102
Depends on: 1643513
Depends on: 1647434
Depends on: 1647492
Depends on: 1647511
Depends on: 1648024
Depends on: 1648100

When I play a Youtube-Playlist where both next and previous song are available only play / pause works using the controls exposed in gnome-shell / using the hardware keys in Firefox 77.
Is there already a bug tracking this? 1635209 sounds related ...

Depends on: 1649636
Depends on: 1648874
Depends on: 1653006
Depends on: 1653390
Depends on: 1654026
Depends on: 1654045
Depends on: 1654247
Depends on: 1654277
Depends on: 1654657
Depends on: 1654959
Depends on: 1655204
Depends on: 1656398
Depends on: 1656642
Depends on: 1657223
Depends on: 1657224
Depends on: 1657682
Depends on: 1657701
Depends on: 1658075
Depends on: 1658380
Depends on: 1658526
Depends on: 1659199
Depends on: 1659644
Depends on: 1660936
Depends on: 1663128
Depends on: 1665211
Depends on: 1665225
Depends on: 1665496
Depends on: 1665527
Depends on: 1666218
Depends on: 1667454
Depends on: 1667459
Depends on: 1667479
Depends on: 1668122
Depends on: 1668139
Depends on: 1668369
Depends on: 1669434
Depends on: 1671626
Whiteboard: [feature-testing-meta]
Depends on: 1673509
Depends on: 1673521
Whiteboard: [feature-testing-meta]
Depends on: 1676045

We have finished most developing for this feature already, the remaining tasks are just improvement or simply bug fixing.
So I will close this bug, but still use this to track any future related issues.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Summary: [meta] Control any media without interacting directly with pages where media are → [meta] Media control tracking bug [*** see URL link for more details ***]
Depends on: 1678357
Depends on: 1683020
Depends on: 1683788
Depends on: 1686148
Depends on: 1686895
You need to log in before you can comment on or make changes to this bug.