1577924 - Urlbar should NOT allow switching between search engines using ctrl-up and down

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Asif Youssuff]

Enabled the megabar on my install, and found that ctrl-down arrow behavior is not what I expect based on my usage of the separate search box.

STR:

1. Enable megabar
2. Do Ctrl-l
3. type in a query
4. do ctrl-down arrow

What happens:

Nothing.

Expected result:

The first search engine suggested in "this time search with" should be selected, doing ctrl-down arrow again should select the next. Hitting enter should search with the selected search engine.

For some reason, the control-up arrow works as expected.

Comment 1

[Harry Twyford]

Hi Asif, what platform are you on? I'm running Nightly on macOS and the option-up/down shortcuts work to select a one-off search-engine in the search box, the old address bar, and the megabar.

Comment 2

[Asif Youssuff]

I am on Linux right now. FWIW, the control-up and down feature is different from the option/alt shortcut (which does work in megabar and the separate search box) -- it switches the search engine sequentially without visually highlighting it.

The Ctrl-up works in the old addressbar, while Ctrl-down does not, just like megabar.

Oddly, I just tested it again, and ctrl-down actually does seem to work -- but it seems to step through items that are invisible, so it seems like it doesn't work.

STR:

1. Have at least r enabled engines.
2. enable megabar
3. Do control-l
4. type a query
5. Do Control-up 4 times
6. Do Control-down

The search engines are now highlighted and are selectable.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think ctrl+up/down in the search bar changes the current engine, I don't think we want the same feature in the urlbar.
Though, the current support for ctrl+up/down in urlbar is broken, as you found. We should decide whether to stop supporting it, or making it just the same as alt+up/down.
As such, I'm marking as a defect the broken behavior, but we won't port the search bar functionality as-is.

Comment 4

[Dão Gottwald [:dao]]

How exactly does this relate to the megabar design? Is this a regression? Is this not an issue with the megabar disabled?

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Yeah, it's not a megabar blocker, this is a bug also with the normal design.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

this is not a regression, we never supported this behavior in the Address Bar. So we don't need special tracking for this

Comment 7

[James Teow [:jteow]]

On Windows, this Ctrl-Up/Ctrl-Down doesn't work the same as OSX.

In our bug scrub meeting, we came to the agreement that we think the solution from here should be that Ctrl-Up/Ctrl-Down should just act like up and down since Alt+Up/Alt+Down already has the behaviour of moving through all the shortcut buttons.

This would avoid having shortcuts having the same behaviour as existing shortcut buttons.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1577924: Ignore ctrl key when arrow/page down/up.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3622cf8a8c84
Ignore ctrl key when arrow/page down/up. r=daleharvey

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3622cf8a8c84