1782594 - Ctrl-PageUp and Ctrl-PageDown get stuck on tabs with focus in the address bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[B.J. Herbison]

Steps to reproduce:

1. Create several tabs.
2. Cycle through the tabs with Ctrl-PageUp and Ctrl-PageDown.
3. Focus in the address bar of one of the tabs.
4. Cycle through the tabs with Ctrl-PageUp and Ctrl-PageDown.

Expected:
2 and 4) Ctrl-PageUp and Ctrl-PageDown cycle through all the tabs.

Actual:
2) As expected.
4) 2) Ctrl-PageUp and Ctrl-PageDown get stuck on the tab with focus in the address bar.

Mozregression says this is caused by the fix for bug 1577924.

6:29.45 INFO: No more integration revisions, bisection finished.
6:29.45 INFO: Last good revision: cac795fd16d2ae8730dcb7ee7653be5e488e1123
6:29.45 INFO: First bad revision: 3622cf8a8c84d9ad167831d8e89b0df70ca1c654
6:29.45 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cac795fd16d2ae8730dcb7ee7653be5e488e1123&tochange=3622cf8a8c84d9ad167831d8e89b0df70ca1c654

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1577924

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1577924, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report and I'm sorry for the inconvenience.
I will fix it soon.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1782594: Revert PageDown/Up key behavior on urlbar.

Comment 5

[Mathew Hodson]

You can add a comment like // falls through to satisfy the no-fallthrough lint.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41e6c6c50504
Revert PageDown/Up key behavior on urlbar. r=daleharvey

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41e6c6c50504