1578100 - The FPS overlay (layers.acceleration.draw-fps) doesn't work when CoreAnimation is enabled

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

In bug 1574745 I broke the FPS overlay in configurations that use native layers, i.e. macOS with CoreAnimation. So the layers.acceleration.draw-fps pref doesn't do anything there at the moment.
The work in this bug will bring the FPS overlay back.

(This is not that urgent and does not need to be tracked for Firefox 70, it's a pref that is only occasionally used by Gecko developers.)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Use DrawTarget::CopySurface in the text renderer. r=mattwoodrow

Depends on D44330

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Remove unused aTextSize argument. r=mattwoodrow

Depends on D44332

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Factor out surface size computation. r=mattwoodrow

Depends on D44333

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Add TextRenderer::RenderTextToDrawTarget. r=mattwoodrow

Depends on D44334

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Factor out DrawTranslationWarningOverlay. r=mattwoodrow

Depends on D44335

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Implement LayerManagerComposite::UpdateDebugOverlayNativeLayers(). r=mattwoodrow

This creates and updates layers that draw the same things as RenderDebugOverlay().
The code is duplicated so that the overlay can be independent of the compositing
layer content drawing. All layers need to be drawn first, and the GPU stats from
that layer are shown in mGPUStatsLayer.

Depends on D44336

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1578100 - Respect the clip when calculating the number of pixels to fill. r=mattwoodrow

This makes the fill rate numbers which are displayed in the FPS overlay a lot more reasonable.
It also requires the TransformAndClipBounds fix from bug 1578045 for correct numbers.

Depends on D44337

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f8f8f958da7
Use DrawTarget::CopySurface in the text renderer. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/e408b810106d
Remove unused aTextSize argument. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1d43d31f95ed
Factor out surface size computation. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/9b78526a3b4a
Add TextRenderer::RenderTextToDrawTarget. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/d8a238d4c34d
Factor out DrawTranslationWarningOverlay. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/f8ced2588497
Implement LayerManagerComposite::UpdateDebugOverlayNativeLayers(). r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/12a11f3c8ab4
Respect the clip when calculating the number of pixels to fill. r=mattwoodrow

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6f8f8f958da7
https://hg.mozilla.org/mozilla-central/rev/e408b810106d
https://hg.mozilla.org/mozilla-central/rev/1d43d31f95ed
https://hg.mozilla.org/mozilla-central/rev/9b78526a3b4a
https://hg.mozilla.org/mozilla-central/rev/d8a238d4c34d
https://hg.mozilla.org/mozilla-central/rev/f8ced2588497
https://hg.mozilla.org/mozilla-central/rev/12a11f3c8ab4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this going to ride Fx71 to release?

Comment 11

[Markus Stange [:mstange]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

Is this going to ride Fx71 to release?

I think that would be acceptable. The alternative would be to uplift both bug 1578099 and this bug to 70, including the three regression fixes from bug 1578310, bug 1578376 and bug 1578305. I'd rather wait for any remaining regressions to shake out before doing that.