1578105 - [Protections Panel] Info button styling is broken on Windows

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Seems like the outline gets set but the background color doesn't. Looks pretty bad.

Comment 1

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1578105 - Fix the styling issue of the info button on Windows. r?nhnt11!

The into button lacks the '-moz-appearance: none;' rule to disable the
system styling. Fix this by adding this.
\

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69454149a5fa
Fix the styling issue of the info button on Windows. r=nhnt11

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/69454149a5fa

Comment 4

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Comment on attachment 9090345 [details]
Bug 1578105 - Fix the styling issue of the info button on Windows. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: The info button of the protection panel on Windows will be broken.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the protection panel by clicking the shield icon in any webpages

2. Hover on the info button on the header of the protection.
3. Check whether the into button has a correct grey-ish background.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a one-line change and only for UI display. It doesn't change any functionality.
• String changes made/needed: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9090345 [details]
Bug 1578105 - Fix the styling issue of the info button on Windows. r?nhnt11!

CSS only fix for newly shipping feature; let's get it into beta 5.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18769c877f82

Comment 7

[Hani Yacoub, Desktop QA]

Attachment: Info button.png

Verified as fixed on Firefox Nightly 71.0a1 (2019-09-08) on Windows 10 x64 and on Windows 7 x32.

I Noticed that on Ubuntu 18.04 x64 the info button looks a bit different when hovering on it and it changes it color from white to dark grey. (See screenshot attached)
Is this behavior intended or there is already a bug logged for it?

Comment 8

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Thanks Hani,

No, this is not intended behavior. The color should stay the same after hovering on it. I filed Bug 1580106 for this.

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 70.0b5 on Windows 10 x64 and on Windows 7 x32.