1580106 - [Protections Panel] The info button shows a wrong color when hovering on it on Linux

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Tim Huang[:timhuang]]

The color of the info button should stay as-is instead of turning to gray when hovering on it on Linux.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1580106 - Fixing the hovering color issue for the toolbarbutton in general on the protections panel on Linux. r?nhnt11!

This patch overrides the color of the toolbarbutton on Linux for the
info button on the protections panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e23d5f8a2d75
Fixing the hovering color issue for the toolbarbutton in general on the protections panel on Linux. r=nhnt11

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e23d5f8a2d75

Comment 4

[Tim Huang[:timhuang]]

Comment on attachment 9091670 [details]
Bug 1580106 - Fixing the hovering color issue for the toolbarbutton in general on the protections panel on Linux. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: The color of the info button would be incorrect when hovering on it on Linux.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Click the shield icon to open the protections panel

2. Hover on the info button
3. Check that the color of the info button doesn't change.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not risky since this is only a CSS change.
• String changes made/needed: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091670 [details]
Bug 1580106 - Fixing the hovering color issue for the toolbarbutton in general on the protections panel on Linux. r?nhnt11!

CSS fix for Skyline feature polish. OK for uplift for beta 7.

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/c86ad828ec2a

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 71.0a1 (2019.09.10) on Ubuntu 18.04 x64.
I can confirm this issue is fixed, I verified using Firefox 71.0a1 latest nightly and 70.0b7 build from Treeherder on Ubuntu 18.04 x64.