1578182 - Clicking "Check for updates" while at the "Available updates" view does not result in new add-on cards

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Rob Wu [:robwu]]

STR:

1. Install an old version of an add-on, e.g. from https://addons.mozilla.org/en-US/firefox/addon/open-bookmark-in-container-tab/versions/
2. Visit about:addons , disable "Update Add-ons automatically" (via the gears menu).
3. Click on "Check for updates"
4. Click on the "Available updates" tab.
5. Uninstall the add-on.
6. Install the old version of the add-on again.
7. Click on "Check for updates".

Expected:

• After step 5, the "Available updates" tab should be hidden, or show a count of 0.
• After step 7, the "Available updates" tab should show a count of 1, and list the add-on update.

Actual:

• After step 5, the "Available updates" tab is shown with a count of 1 (suggesting that there should be 1 available update). - this appears to be bug 1548836
• After step 7, the "Available updates" tab is still empty. The expected card only re-appears when I switch to a different tab of the about:addons page and back. There is a "View Available Updates" link/button, but upon click the updates view is not updated.

Reproduced in Firefox 68.0.1
Reproduced in Firefox 70.0a1 buildID 20190901214807

Comment 1

[Mark Striemer [:mstriemer]]

So the update check happens in extensions.js currently, which is fine on other pages since going to the available updates tab will render the updates. There doesn't seem to be an event we can listen for since the code just calls findUpdate for each add-on that's installed, and has its own completion tracking. Reaching into the HTML views and calling render() on the available updates will make it update. We can likely come up with something nicer than that once the header is in the HTML views.

As for the count, it probably shouldn't count installs that are for add-ons that are no longer installed. This looks like it might've been a bug in the old version too. The underlying issue appears to be that the install object isn't cleaned up when the add-on is uninstalled.

Comment 2

[Wayne Mery (:wsmwk)]

related to bug 1175917 ?