1578187 - [Protections Panel] Font size has become too large on Ubuntu 19.04

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Kestrel]

Attachment: Large Protections Panel font size on Ubuntu 19.04

The Protections Panel font size on Ubuntu 19.04 with default 11pt font size (14.6667px) increased from 1.1em (16.1333px) to 1.18rem (17.3px) and now feels a bit too big.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c7a1d0fda0e9fbb6293ee15e0596361d98b7979&tochange=2b29ae6ba20f9c8edd8e51be7d594884b79fbf52

Regressed by Bug 1559258.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1578187 - Reduce Protections and Identity panel scale on linux. r=dao

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: With the patch

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Builds for testing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=21d47316a8cabe6c6a9f805ac3b99482bd946918

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96ded2cad7f8
Reduce Protections and Identity panel scale on linux. r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/96ded2cad7f8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift when you get a chance.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9090803 [details]
Bug 1578187 - Reduce Protections and Identity panel scale on linux. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Protections Panel is too large on Linux. This is a prominent visual annoyance.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the Protections Panel by clicking the shield icon in the URL bar on Linux. The panel's font size should be consistent with the rest of the UI.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change to scale down the font size and dimensions of the panel.
• String changes made/needed: None

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue on an old Nightly build before the fix on Ubuntu 19.04 set up in virtual machine, verified that the font size is now consistent with the rest of the UI on latest Nightly from 2019-09-17.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9090803 [details]
Bug 1578187 - Reduce Protections and Identity panel scale on linux. r=dao

Protections Panel visual tweak, approved for 70.0b8.

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c631ba284d17

Comment 11

[Bogdan Maris, Desktop Test Engineering]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #8)

Reproduced the initial issue on an old Nightly build before the fix on Ubuntu 19.04 set up in virtual machine, verified that the font size is now consistent with the rest of the UI on latest Nightly from 2019-09-17.

Looks verified on Firefox 70.0b8 as well.