1578302 - Opening Activity manager in TB while gloda indexing is in progress causes TypeError: Argument 1 of Range.selectNodeContents is not an object. customElements.js:529:15

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[:aceman]

When I enable the Gloda indexer in TB and it has some work to do and is in progress, opening the Activity manager and watching the progress causes these errors in the console:

XML Parsing Error: not well-formed
Location: moz-nullprincipal:{ca282f18-a14c-4dd3-93e6-12975b8bd594}
Line Number 18, Column 82: {ca282f18-a14c-4dd3-93e6-12975b8bd594}:18:82

TypeError: Argument 1 of Range.selectNodeContents is not an object. customElements.js:529:15

Happens also in Safe mode. It didn't happen immediately, but after several opens of the Activity manager I get the errors consistently every time.

Comment 1

[:aceman]

The UUID-resembling string is not an addon ID, it changes every time.

Comment 2

[Magnus Melin [:mkmelin]]

I wonder if it's the case that we have too many nodes selected. I think I saw something like this when manually selecting tens of thousands of messages and trying to move them. Not sure what happens, but maybe Range.selectNodeContents just can't cope with massive amounts of data.

Comment 3

[Wayne Mery (:wsmwk)]

Geoff, any ideas?

Comment 4

[Geoff Lankow (:darktrojan)]

I'm not seeing this. I remember a while ago the activity manager would show the string "null" where it looked like something else should be. Perhaps it is related and has been fixed, because I don't see that any more either.

Comment 5

[Wayne Mery (:wsmwk)]

Aceman, still seeing this?

Comment 6

[Magnus Melin [:mkmelin]]

I believe this is related to ranges and how they do (or rather do not) work with very large selections.

Comment 7

[Stéphane Gourichon]

TL;DR: Bug observed here, too, today.

Context

TB 68.10.0 (64 bits) on Xubuntu 20.04, official package.

Not 100% sure if global indexing was active. The reason I look at output is that it looks like Thunderbird re-reads folders from IMAP server that it had plenty of time to read and index in the past. This may or may not be related.

Symptom

Anyway, here too opening activity window causes this on terminal output (stdout or stderr):

JavaScript error: chrome://global/content/customElements.js, line 483: TypeError: Argument 1 of Range.selectNodeContents is not an object.

Javascript console then progressively shows occurrences of this error:

Erreur d’analyse XML : mal formé
Emplacement : moz-nullprincipal:{8bc3527e-07cb-4126-be56-ff4a45b5c243}
Numéro de ligne 19, Colonne 56 : {8bc3527e-07cb-4126-be56-ff4a45b5c243}:19:56
TypeError: Argument 1 of Range.selectNodeContents is not an object.customElements.js:483:15
parseXULToFragment chrome://global/content/customElements.js:483
connectedCallback chrome://messenger/content/activity-widgets.js:591
addActivityElement chrome://messenger/content/activity.js:129
startup chrome://messenger/content/activity.js:198
onload chrome://messenger/content/activity.xul:1

until it is repeated around 250 times.
Then error console becomes quiet again.

Thank you for your attention.

Comment 8

[Wayne Mery (:wsmwk)]

Alfred, can you confirm Geoff's finding that this does not reproduce?

Comment 9

[Alfred Peters [:infofrommozilla]]

With TB78.5.1 I got:

• XML Parsing Error: not well-formed
  Location: moz-nullprincipal:{6c416d4c-309f-4c2b-92ba-3edee41d1249}
  Line Number 19, Column 56: {6c416d4c-309f-4c2b-92ba-3edee41d1249}:19:56
• Uncaught Error: not well-formed XML
  parseXULToFragment chrome://global/content/customElements.js:566
  connectedCallback chrome://messenger/content/activity-widgets.js:603
  addActivityElement chrome://messenger/content/activity.js:129
  onAddedActivity chrome://messenger/content/activity.js:290
  addActivity resource://gre/modules/ActivityManager.jsm:65
  onAlert resource:///modules/activity/alertHook.jsm:58
  customElements.js:566:17
• Async statement execution returned with '1', 'ambiguous column name: expire_ms' PlacesExpiration.jsm:690
  PEX_handleError resource://gre/modules/PlacesExpiration.jsm:690

Comment 10

[Alfred Peters [:infofrommozilla]]

With current trunk TB: No, I can't reproduce it.

Comment 11

[Wayne Mery (:wsmwk)]

Thanks for the thorough check! So there is hope it will be gone in a future release.

Comment 12

[Magnus Melin [:mkmelin]]

Actually, this is real just not easy to reproduce.

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: bug1578302_activity_manager_xml.patch

One char fix.

Comment 14

[Magnus Melin [:mkmelin]]

(I don't know about the range stuff.)

Comment 15

[Magnus Melin [:mkmelin]]

Comment on attachment 9195060 [details] [diff] [review]
bug1578302_activity_manager_xml.patch

This is a small one to review, if you want something to land ;)

Comment 16

[Geoff Lankow (:darktrojan)]

I think this should solve the Range error too. At a guess I'd say this doesn't work and the code carries on down to where the Range.selectNodeContents call is made.

Aceman, when this code lands can you check if the problem goes away?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45fcaf111e0b
fix malformed xml for MozActivityWarningRichlistItem. r=darktrojan

Comment 18

[Magnus Melin [:mkmelin]]

Comment on attachment 9195060 [details] [diff] [review]
bug1578302_activity_manager_xml.patch

[Approval Request Comment]
One char safe fix. Prevents some cases in the activity manager from working properly.

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9195060 [details] [diff] [review]
bug1578302_activity_manager_xml.patch

[Triage Comment]
Approved for esr78

Comment 20

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/ea68db1734c1