Closed Bug 1578375 Opened 1 year ago Closed 1 year ago

Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar

Categories

(Firefox :: Address Bar, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: perf)

Attachments

(1 file)

__rebuid queries layout, then does a bunch of calculations only to set a height on the buttons contains as explained in this comment:

// If the <div> with the list of search engines doesn't have
// a fixed height, the panel will be sized incorrectly, causing the bottom
// of the suggestion <tree> to be hidden.

Today the urlbar uses neither a popup nor a tree so I don't think we need this hack anymore.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc41162193ba
Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=adw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9090007 [details]
Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=mak

Beta/Release Uplift Approval Request

  • User impact if declined: this is needed for bug 1567384
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Mostly moving legacy code around so it doesn't run for the address bar as it shouldn't be needed there
  • String changes made/needed:
Attachment #9090007 - Flags: approval-mozilla-beta?

Comment on attachment 9090007 [details]
Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=mak

Fix to help with accessibility and search bar from a regression in 70. OK for uplift for beta 5.

Attachment #9090007 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1573358
You need to log in before you can comment on or make changes to this bug.