1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

__rebuid queries layout, then does a bunch of calculations only to set a height on the buttons contains as explained in this comment:

// If the <div> with the list of search engines doesn't have
// a fixed height, the panel will be sized incorrectly, causing the bottom
// of the suggestion <tree> to be hidden.

Today the urlbar uses neither a popup nor a tree so I don't think we need this hack anymore.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc41162193ba
Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=adw

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dc41162193ba

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9090007 [details]
Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: this is needed for bug 1567384
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly moving legacy code around so it doesn't run for the address bar as it shouldn't be needed there
• String changes made/needed:

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9090007 [details]
Bug 1578375 - Stop flushing layout in SearchOneOffs::__rebuild when used with the address bar. r=mak

Fix to help with accessibility and search bar from a regression in 70. OK for uplift for beta 5.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4a413a2ebbb