1578422 - Failure to setup shared memory in the CrashReporterClient should crash on Nightly to catch problems

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement, P1)

Description

[Bob Owen (:bobowen) (PTO until 5th Jan)]

Currently, if the creation and sharing of shared memory (for crash annotations) fails in CrashReporterClient::InitSingleton, it is silently ignored.

We should make this crash in Nightly (and DevEdition), so that we don't silently lose annotations.
It makes sense to ignore it for Beta and Release.

Comment 1

[Bob Owen (:bobowen) (PTO until 5th Jan)]

jld: just so it doesn't come as a surprise, I'm just intending to land your patch here, with the commit comment updated.

try push:
https://treeherder.mozilla.org/#/jobs?repo=try&duplicate_jobs=visible&revision=f9dbda6bae1f64b01ad30287ea15dbcc761c3ec0

Comment 2

[Jed Davis [:jld] (away until 12-29)]

Commit message looks good to me; thanks for taking care of this.

Comment 3

[Bob Owen (:bobowen) (PTO until 5th Jan)]

Attachment: Bug 1578422: MOZ_DIAGNOSTIC_ASSERT when shared memory setup fails in CrashReporterClient::InitSingleton. r=gsvelto!

This will help to catch changes that cause a loss of annotations without
affecting Release or Beta.
This also makes CrashReporterClient::InitSingleton return void as the previous
bool was ignored in all cases.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a222c75f5c
MOZ_DIAGNOSTIC_ASSERT when shared memory setup fails in CrashReporterClient::InitSingleton. r=gsvelto

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a8a222c75f5c