Open Bug 1578425 Opened 5 years ago Updated 2 years ago

Rename most "target" getters to "currentTarget"

Categories

(DevTools :: Framework, task, P2)

task

Tracking

(Fission Milestone:Future)

Fission Milestone Future

People

(Reporter: ochameau, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-future)

In order to better align the fact that a given toolbox may have its top level target to change to another instance whenever the inspected target navigates to another process,
we should rename existing target attributes we have in the codebase to currentTarget.
But we should do that only if the JS Class the attribute is on can change to another target.
In a few places, like WebConsoleConnectionProxy, a given class instance is bound to only one target and will be destroyed if the related target is destroyed or navigates.

Here, this bug is specific to the Toolbox class and its target attribute:
https://searchfox.org/mozilla-central/rev/e04021f29e6d8a37753ba2b510432315ce05a8d7/devtools/client/framework/toolbox.js#478-485

Type: enhancement → task
Priority: -- → P3
Summary: Rename Toolbox.target to currentTarget → Rename most "target" getters to "currentTarget"
Blocks: 1592575
Whiteboard: dt-fission-m2-mvp

Tracking dt-fission-m2 bugs for Fission Nightly (M6)

Fission Milestone: --- → M6
Priority: P3 → P2

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6 → M6c
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M6c → MVP

Moving old "dt-fission-m2-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Fission Milestone: MVP → Future
Whiteboard: dt-fission-m2-reserve → dt-fission-future
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.