Rename most "target" getters to "currentTarget"
Categories
(DevTools :: Framework, task, P2)
Tracking
(Fission Milestone:Future)
Fission Milestone | Future |
People
(Reporter: ochameau, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-future)
In order to better align the fact that a given toolbox may have its top level target to change to another instance whenever the inspected target navigates to another process,
we should rename existing target
attributes we have in the codebase to currentTarget
.
But we should do that only if the JS Class the attribute is on can change to another target.
In a few places, like WebConsoleConnectionProxy, a given class instance is bound to only one target and will be destroyed if the related target is destroyed or navigates.
Here, this bug is specific to the Toolbox class and its target
attribute:
https://searchfox.org/mozilla-central/rev/e04021f29e6d8a37753ba2b510432315ce05a8d7/devtools/client/framework/toolbox.js#478-485
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
We may also rename the target
gatter defined in each panel:
https://searchfox.org/mozilla-central/search?q=get+target&case=false®exp=false&path=devtools%2Fclient
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Tracking dt-fission-m2 bugs for Fission Nightly (M6)
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
Comment 5•4 years ago
|
||
Moving old "dt-fission-m2-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.
Reporter | ||
Updated•4 years ago
|
Updated•2 years ago
|
Description
•