1592575 - [meta] Enable target switching - Keep the toolbox opened when navigating to another process

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Bug 1565263 introduced devtools.target-switching.enabled, which, when set to true prevent the toolbox from closing when we navigate to a URL that requires to be loaded in another process, different from the previous URL.
This happens when navigating from any http URL to about:robots, as about:robots is loaded in the main process.
This also happen when enabling fission via fission.autostart, as two http URL may be loaded in distinct processes.

In order to enable this preference, all panels should support the new "target switching" codepath. Otherwise the one which don't, will be 100% broken when such navigation happen.

The necesarry refactoring is about refactoring the panels in order to use the TargetList API implemented in bug 1471754.
The panels should no longer assume that there is one static top level target. Instead, this top level target can change over time.:

• Some panel are memoizing the top level target via a target attribute. This should be refactored in order to name this target attribute currentTarget and refer to the TargetList's targetFront attribute (bug 1578425).
• Panels should be using TargetList.watchTargets in order to retrieve:
  • the current top level target
  • the additional targets (the already existing ones and the new one to be created)
  • the next top level target if we navigate to another process

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

DevTools target switching probably doesn't block Fission dogfooding (M5), but we'd like it soon, so I'll tentatively monitor this meta bug for Fission M5.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #2)

DevTools target switching probably doesn't block Fission dogfooding (M5), but we'd like it soon, so I'll tentatively monitor this meta bug for Fission M5.

Moving back to M6 Nightly because we're reducing the scope of M5 Dogfooding to real blockers only, not just bugs that will get fixed soon.

Comment 5

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 6

[Chris Peterson [:cpeterson]]

Moving these DevTools Fission bugs from Fission's old M6 Nightly milestone to M7 Beta. I am assuming these bugs would have the dt-fission-m2-mvp whiteboard tag if they were Fission Nightly blockers.

Comment 7

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 8

[Chris Peterson [:cpeterson]]

Moving old "dt-fission" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 9

[Alexandre Poirot [:ochameau]]

We enabled client side target switching a while ago, so this has been fixed.
Issues may still occurs because of lack of server side target switching we is tracked independently via bug 1698891.