1578427 - Crash in [@ mozilla::fontlist::Family::SearchAllFontsForChar]

Status: RESOLVED DUPLICATE of bug 1548813

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-7d69ccc3-0329-4863-9fcc-1ec650190831.

Seen while looking at nightly crash stats - small volume Win crash which started in 20190830215433, while nightly was in 70: https://bit.ly/2lXt6EZ

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=23824765c6aa026ccc3e3aea1c851c07ab8937ee&tochange=cae93ef1993e02a136ef64d974856071b905997f

Bug 1576846 is in the range. ni on Jonathan.

Top 10 frames of crashing thread:

0 xul.dll mozilla::fontlist::Family::SearchAllFontsForChar gfx/thebes/SharedFontList.cpp:306
1 xul.dll class gfxFont* gfxFontGroup::FindFallbackFaceForChar gfx/thebes/gfxTextRun.cpp:2714
2 xul.dll gfxFontGroup::FindFontForChar gfx/thebes/gfxTextRun.cpp
3 xul.dll gfxFontGroup::InitScriptRun<char16_t> gfx/thebes/gfxTextRun.cpp:2486
4 xul.dll static void gfxFontGroup::InitTextRun<char16_t> gfx/thebes/gfxTextRun.cpp:2408
5 xul.dll gfxFontGroup::MakeTextRun gfx/thebes/gfxTextRun.cpp:2280
6 xul.dll nsFontMetrics::GetWidth gfx/src/nsFontMetrics.cpp:290
7 xul.dll nsLayoutUtils::AppUnitWidthOfString layout/base/nsLayoutUtils.cpp:5977
8 xul.dll int nsIRenderingContextBidiProcessor::GetWidth layout/base/nsBidiPresUtils.cpp:2389
9 xul.dll nsBidiPresUtils::ProcessText layout/base/nsBidiPresUtils.cpp:2240

Comment 1

[Jonathan Kew [:jfkthame]]

This is from a user who has enabled gfx.e10s.font-list.shared for testing (it's preffed-off by default); very possibly a variant of bug 1578154 (perhaps even from the same user).

We need to figure out and resolve these crashes before preffing-on this feature for users in general, obviously.

Comment 2

[blinky]

Steps to reproduce:

1. Set gfx.e10s.font-list.shared to true.
2. Restart Firefox.
3. Download Font Loader.
4. Download Franklin Gothic Book Regular.ttf.
5. Open https://bugzilla.mozilla.org/attachment.cgi?id=8924254.
6. Open the Font Loader, Click on the Add Fonts button, Select the font file Franklin Gothic Book Regular.ttf then click Open.
7. Click on the Load button.

Actual results:

The tab crashed.

Crash report: bp-4441779e-e5d6-493c-9420-ae4770190905

Top 10 frames of crashing thread:

0 xul.dll mozilla::fontlist::Family::FindAllFacesForStyle gfx/thebes/SharedFontList.cpp:191
1 xul.dll mozilla::fontlist::Family::FindFaceForStyle gfx/thebes/SharedFontList.cpp:298
2 xul.dll class gfxFontEntry* gfxPlatformFontList::SystemFindFontForChar gfx/thebes/gfxPlatformFontList.cpp:733
3 xul.dll gfxFontGroup::FindFontForChar gfx/thebes/gfxTextRun.cpp:3008
4 xul.dll gfxFontGroup::InitScriptRun<char16_t> gfx/thebes/gfxTextRun.cpp:2486
5 xul.dll static void gfxFontGroup::InitTextRun<char16_t> gfx/thebes/gfxTextRun.cpp:2408
6 xul.dll gfxFontGroup::MakeTextRun gfx/thebes/gfxTextRun.cpp:2280
7 xul.dll void BuildTextRunsScanner::FlushFrames layout/generic/nsTextFrame.cpp:1640
8 xul.dll void BuildTextRunsScanner::ScanFrame layout/generic/nsTextFrame.cpp:2008
9 xul.dll nsTextFrame::EnsureTextRun layout/generic/nsTextFrame.cpp:2937

Comment 3

[Jonathan Kew [:jfkthame]]

This looks like it may be the shared-font-list-enabled version of bug 1548813, for which a patch has just been posted (awaiting review). I'll try to check whether that fixes this issue as well.

Comment 4

[Jonathan Kew [:jfkthame]]

blinky, thank you for the STR in comment 2; that worked for me on Win10 as well.

Since bug 1548813 landed, I can no longer reproduce this crash, and it makes sense (given the contents of the testcase) for that patch to have fixed it. Could you confirm if it is also fixed for you with latest Nightly builds? Thanks.

Comment 5

[blinky]

I confirm this bug has been fixed in the latest Nightly build. Thanks.

Comment 6

[Jonathan Kew [:jfkthame]]

OK, thanks for confirming. I think we can resolve this as a dupe of 1548813, then - a different signature, but it was the same underlying bug.