Closed Bug 1578445 Opened 3 months ago Closed Last month

Make sure accessibility on the TIP result type is correct

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.4 - Oct 14 - 20
Tracking Status
firefox71 --- fixed

People

(Reporter: harry, Assigned: harry)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [access-p1])

Attachments

(1 file)

No description provided.
Priority: -- → P2

Contrast and keyboard selection already look good.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 71.3 - Sept 30 - Oct 13
Points: 3 → 2
Keywords: access
Attachment #9098391 - Attachment description: Bug 1578445 - Add roles and aria-labels to tip elements. r?dao → Bug 1578445 - Add roles and aria attributes to tip elements. r?dao

Bumping the points back up since the test changes made the scope of this patch a bit larger than expected.

Iteration: 71.3 - Sept 30 - Oct 13 → 71.4 - Oct 14 - 20
Points: 2 → 3
Whiteboard: [access-p1]
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62d172103a78
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c0ed99d462c
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Flags: needinfo?(htwyford)

Backed out changeset 8c0ed99d462c (bug 1578445) for browser-chrome failures at browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js

Backout: https://hg.mozilla.org/integration/autoland/rev/c260b3893967535faf023573fdd429fc48738778

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8c0ed99d462c936bad44847ecb40d92f6099bdd8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271741143&repo=autoland&lineNumber=3456

task 2019-10-17T17:13:30.423Z] 17:13:30 INFO - Console message: [JavaScript Error: "firstElementChild.get is not a function" {file: "resource:///modules/UrlbarView.jsm" line: 1070}]
[task 2019-10-17T17:13:30.424Z] 17:13:30 INFO - _getFirstSelectableElement@resource:///modules/UrlbarView.jsm:1070:45
[task 2019-10-17T17:13:30.424Z] 17:13:30 INFO - _updateIndices@resource:///modules/UrlbarView.jsm:974:34
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - _removeStaleRows@resource:///modules/UrlbarView.jsm:1024:10
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - onQueryFinished@resource:///modules/UrlbarView.jsm:430:12
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - notify@resource:///modules/UrlbarController.jsm:602:25
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - startQuery@resource:///modules/UrlbarController.jsm:142:12
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - asyncstartQuery@resource:///modules/UrlbarInput.jsm:837:52
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - _on_input@resource:///modules/UrlbarInput.jsm:1891:10
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - handleEvent@resource:///modules/UrlbarInput.jsm:303:23
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - fireInputEvent@resource://testing-common/UrlbarTestUtils.jsm:350:28
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - promiseAutocompleteResultPopup@resource://testing-common/UrlbarTestUtils.jsm:58:12
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - async
test@chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js:99:25
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1067:34
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - async
Tester_execTest@chrome://mochikit/content/browser-test.js:1102:11
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:930:14
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO -
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - Buffered messages finished
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | Test timed out -
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - GECKO(2999) | MEMORY STAT | vsize 20975728MB | residentFast 1518MB
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - TEST-OK | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | took 90022ms
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | Found a tab after previous test timed out: about:blank -
[task 2019-10-17T17:13:30.431Z] 17:13:30 INFO - checking window state

Flags: needinfo?(htwyford)

Looks like what happened here is that I fixed the issue that caused the first backout, but then some weirdness on Phabricator reverted that fix before I pushed the second time.

Nonetheless, I'm doing another try run just to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bd95b3331e6947c8f00134b57b4300b836364f4

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f379c7775ca
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.