1578445 - Make sure accessibility on the TIP result type is correct

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Comment 1

[Harry Twyford]

Attachment: Bug 1578445 - Add roles and aria attributes to tip elements. r?dao

Comment 2

[Harry Twyford]

Contrast and keyboard selection already look good.

Comment 3

[Harry Twyford]

Bumping the points back up since the test changes made the scope of this patch a bit larger than expected.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62d172103a78
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie

Comment 5

[Oana Pop-Rus]

Backed out changeset 62d172103a78 (bug 1578445) for bc failures in browser/browser_ext_urlbar.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-6%2Cm-fis%28bc6%29&revision=62d172103a78cb1241563dfdf0bf77b89fd80064

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271713067&repo=autoland&lineNumber=14796

Backout: https://hg.mozilla.org/integration/autoland/rev/db08bedeceb5df54439edf2d04d55fd05af47bb8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c0ed99d462c
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 8c0ed99d462c (bug 1578445) for browser-chrome failures at browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js

Backout: https://hg.mozilla.org/integration/autoland/rev/c260b3893967535faf023573fdd429fc48738778

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8c0ed99d462c936bad44847ecb40d92f6099bdd8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271741143&repo=autoland&lineNumber=3456

task 2019-10-17T17:13:30.423Z] 17:13:30 INFO - Console message: [JavaScript Error: "firstElementChild.get is not a function" {file: "resource:///modules/UrlbarView.jsm" line: 1070}]
[task 2019-10-17T17:13:30.424Z] 17:13:30 INFO - _getFirstSelectableElement@resource:///modules/UrlbarView.jsm:1070:45
[task 2019-10-17T17:13:30.424Z] 17:13:30 INFO - _updateIndices@resource:///modules/UrlbarView.jsm:974:34
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - _removeStaleRows@resource:///modules/UrlbarView.jsm:1024:10
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - onQueryFinished@resource:///modules/UrlbarView.jsm:430:12
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - notify@resource:///modules/UrlbarController.jsm:602:25
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - startQuery@resource:///modules/UrlbarController.jsm:142:12
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - asyncstartQuery@resource:///modules/UrlbarInput.jsm:837:52
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - _on_input@resource:///modules/UrlbarInput.jsm:1891:10
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - handleEvent@resource:///modules/UrlbarInput.jsm:303:23
[task 2019-10-17T17:13:30.425Z] 17:13:30 INFO - fireInputEvent@resource://testing-common/UrlbarTestUtils.jsm:350:28
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - promiseAutocompleteResultPopup@resource://testing-common/UrlbarTestUtils.jsm:58:12
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - asynctest@chrome://mochitests/content/browser/browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js:99:25
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1067:34
[task 2019-10-17T17:13:30.426Z] 17:13:30 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1102:11
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:930:14
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-17T17:13:30.427Z] 17:13:30 INFO -
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - Buffered messages finished
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | Test timed out -
[task 2019-10-17T17:13:30.428Z] 17:13:30 INFO - GECKO(2999) | MEMORY STAT | vsize 20975728MB | residentFast 1518MB
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - TEST-OK | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | took 90022ms
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-17T17:13:30.430Z] 17:13:30 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_urlbar_tip.js | Found a tab after previous test timed out: about:blank -
[task 2019-10-17T17:13:30.431Z] 17:13:30 INFO - checking window state

Comment 8

[Harry Twyford]

Looks like what happened here is that I fixed the issue that caused the first backout, but then some weirdness on Phabricator reverted that fix before I pushed the second time.

Nonetheless, I'm doing another try run just to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bd95b3331e6947c8f00134b57b4300b836364f4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f379c7775ca
Add roles and aria attributes to tip elements. r=dao,fluent-reviewers,Gijs,Jamie

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7f379c7775ca