Closed Bug 1606921 Opened 4 years ago Closed 4 years ago

Check accessibility on Interventions

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED

People

(Reporter: bugzilla, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: access)

We should work with the a11y team to ensure that Interventions are fully accessible. We already did this check when it ran as an experiment, but it doesn't hurt to check again.

Priority: -- → P2
See Also: → 1578445
Keywords: access

It'd probably be easiest to do this by asking a11y to audit this feature once it lands. I'm marking Interventions landing in-tree as a blocker.

Depends on: 1606917

it should now be possible for a11y team to enable the pref and test the feature.
The preference is browser.urlbar.update1.interventions, when typing specific phrases, like "firefox slow", "firefox crashing" or "firefox update" a new intervention result type appears among results, that provides additional functionality (help) to the user.

Please let us know about your doubts or feedback.

Flags: needinfo?(jteh)

This works pretty well from a screen reader perspective. When you press down arrow to examine autocomplete suggestions, the tip text is read, followed by the first button. The second button is read if you press down arrow again. Examining this in a real world context, two things come to mind:

  1. A screen reader user might not examine the autocomplete suggestions with down arrow and so might not know this has appeared. I guess a sighted user would always be aware of it, even if they chose not to activate it? We could get around this by forcing a screen reader notification, but honestly, I think this would be annoying for users and I don't think we should do it. I think this is just an inherent problem with current web autocomplete a11y. I flag it here only so it's noted.
  2. A screen reader user isn't necessarily aware that this is a tip, as opposed to a normal result. The announcement is slightly different because of the message, grouping and button, but that doesn't necessarily mean anything specific to a user. I'm concerned a user won't know they can trust this as a recommendation from the browser, as opposed to some arbitrary web result.
    :mak, I see there is a tip icon image. How obvious is this visually and what does this look like?
    I wonder whether we should prefix the grouping name with something like "tip: " to make this clear to screen reader users. :marcoz, what do you think?

NI Yura for a low vision assessment.

Flags: needinfo?(yzenevich)
Flags: needinfo?(mzehe)
Flags: needinfo?(mak)
Flags: needinfo?(jteh)

(In reply to James Teh [:Jamie] from comment #3)

  1. A screen reader user isn't necessarily aware that this is a tip, as opposed to a normal result. The announcement is slightly different because of the message, grouping and button, but that doesn't necessarily mean anything specific to a user. I'm concerned a user won't know they can trust this as a recommendation from the browser, as opposed to some arbitrary web result.
    :mak, I see there is a tip icon image. How obvious is this visually and what does this look like?
    I wonder whether we should prefix the grouping name with something like "tip: " to make this clear to screen reader users. :marcoz, what do you think?

We should definitely do that, it must be highlighted to a screen reader user in some form, or they won't know that this comes from the browser internals rather than some search engine autosuggestion or a result from their history or bookmarks.

Flags: needinfo?(mzehe)

(In reply to Marco Zehe (:MarcoZ) from comment #4)

I wonder whether we should prefix the grouping name with something like "tip: " to make this clear to screen reader users. > 

We should definitely do that, it must be highlighted to a screen reader user in some form, or they won't know that this comes from the browser internals rather than some search engine autosuggestion or a result from their history or bookmarks.

Okay. I suggest giving the tip icon alt="tip:" (the colon is deliberate), giving it an id and then putting this before the title id in the aria-labelledby for the group:
https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/browser/components/urlbar/UrlbarView.jsm#1031
So we should end up with something like aria-labelledby="urlbarView-row-1-icon urlbarView-row-1-title".

The intervention can provide its own icon depending on the action, by default it's a light bulb (and currently we only use that). I think it would be ok to not differentiate for screen readers depending on the icon, but just provide an alt, that's a great idea.

Flags: needinfo?(mak)

(In reply to Marco Bonardo [:mak] from comment #6)

The intervention can provide its own icon depending on the action, by default it's a light bulb (and currently we only use that). I think it would be ok to not differentiate for screen readers depending on the icon, but just provide an alt, that's a great idea.

I'm mildly concerned that if the icon can be changed, we may one day need the alt to be different also. Whether we support that now or later doesn't worry me too much, but I thought it worth flagging in case it's easier to deal with this now. Either way, if we ever use another icon for a tip, we need to evaluate whether the alt text is correct.

Using a different alt should be technically simple, we just need to remember to do it.

Depends on: 1613603

Filed bug 1613603 for the alt attribute, as for the other accessibility we'll keep this open for further feedback or resolution once we're happy with the status.

(In reply to James Teh [:Jamie] from comment #3)

NI Yura for a low vision assessment.

Contrast-wise looks good, focus styling is good too, thanks!

Flags: needinfo?(yzenevich)

Jamie, we are looking for final sign-offs of features, now that interventions are enabled in Nightly, is there any a11y blockers for shipping the feature, or have all of your concerns been addressed? If things look good, feel free to resolve this bug.

Flags: needinfo?(jteh)

We're all good here.

Flags: needinfo?(jteh) → a11y-review+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.