1578448 - img.complete does not become false immediately when a srcset attribute is set on the image

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec at https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-complete it should, as far as I can tell: the first two bullet points stop applying immediately, and the last two points can only start to apply async when srcset is involved, right?

Comment 1

[Edgar Chen [:edgar]]

Bug 1578419 adds more tests.

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=025a893d883ce5c98e6f4febc4d19b4f6dbc7a24

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1578448 - Make img.complete align with spec;

If the img has srcset attribute and the current request isn't complete or broken,
the img.complete should return false per spec,
https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-complete.

We should check srcset or src attribute, checking only mCurrentRequest isn't
enough given that updating mCurrentRequest happens async.

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=800d27bc3fe8393480f5cbb90aeada26a6e25e5f

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=808ecc7670a2509874407efd62aa96c2ee70d37e&group_state=expanded&selectedJob=265244632

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5d436985831
Make img.complete align with spec; r=bzbarsky

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1543810) for failing in browser_togglePointerEventsNone.js CLOSED TREE

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266136994&repo=autoland&lineNumber=22333

Backout: https://hg.mozilla.org/integration/autoland/rev/8a08bd085c4abf6ce2fcf331c2b8245e4190786a

Comment 8

[Edgar Chen [:edgar]]

(In reply to Noemi Erli[:noemi_erli] from comment #7)

Backed out 2 changesets (Bug 1543810) for failing in browser_togglePointerEventsNone.js CLOSED TREE

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266136994&repo=autoland&lineNumber=22333

Backout: https://hg.mozilla.org/integration/autoland/rev/8a08bd085c4abf6ce2fcf331c2b8245e4190786a

Is the patch of this bug backed out, too? It doesn't look like the change in this bug will causes the failure in browser_togglePointerEventsNone.js.

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b5d436985831

Comment 10

[Chris Mills [:cmills]]

Sheppy, would this affect the HTMLImageElement docs you've been writing?