Toolbar icon disappears
Categories
(Thunderbird :: Add-Ons: General, defect)
Tracking
(Not tracked)
People
(Reporter: wojtek, Unassigned)
Details
Attachments
(2 files)
thunderbird.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
- instal plugin with toolbar icon (in my case https://addons.thunderbird.net/en-US/thunderbird/addon/allow-html-temp/)
- add it to toolbar
Actual results:
Icon is added but disappears on it's own after a while (sometimes within same session, sometimes after a couple of restarts)
Expected results:
Icon should remain where I placed it
|
||
Comment 1•6 years ago
|
||
Might has something to do with changes to add-ons in 68. Do you use any other addons that would appear in the tool bar? Are they sticking around?
Unfortunately this is the only one. I could test different addons but after quick glance I couldn't find anything that would help with testing (and adding addons in Tb! requires a bit of work with downloading it to different location and then manually installing via addon-manager)
|
|
||
Updated•6 years ago
|
|
||
Comment 3•6 years ago
|
||
This working properly as far as I can tell. Unless you have any other information about when it happens or what might be causing it, there's not a lot we can do.
I played with it a bit and it seems to be 100% reproducible:
- add icon to toolbar
- restart thunderbird
- icon is missing
It seems to happen only to extension icons though.
A couple of more observations (maybe relevant):
- it's not the "mail toolbar" (with hamburger menu) - it seems like main toolbar that can't be disabled
- extension icon is missing from customisation window
- when dragging icon is not visible, nor the exact location where it would be inserted (vertical bar, like in "mail toolbar")
- it does seem to stick to 'mail toolbar'
(I'll attach picture and video shortly)
|
||
Comment 7•6 years ago
|
||
What is the "Main Toolbar"?
I only have View > Toolbars with Menu Bar, Mail Toolbar, Folder Pane Toolbar, Quick Filter Bar and Status bar.
The icon does not stay in the Menu Bar. It does stay in the Mail Toolbar and Tab bar for me.
What is the "Main Toolbar"?
To be honest - I don't know. In my setup it's the to-most strip of UI with icons, but I have this setup for the past ~10 years and it's possible, that in Thunderbird nomenclature it would be "Menu bar". Though, in case of macOS, menu is not part of the window (as you can see in the screenshot.
Under macOS in View > Toolbars I have:
- Mail toolbar (checked temporarily for the tests)
- Folder pan toolbar (unchecked)
- Quick filter bar (checked)
- Status bar (checked)
It seems that there is no entry in that menu that corresponds with my "toolbar"
|
|
||
Comment 9•6 years ago
|
||
Yeah, it looks like your toolbar is the menu bar. I don't think it's intended that you can edit it on mac os.
Additionally, it's outside the toolbox that the add-on's button lives in, that's probably what's causing the problem. Although that is something that could be fixed, I don't think it is worthwhile, given changes in the pipeline for both toolbars and add-ons.
|
Reporter | |
Comment 10•6 years ago
|
||
OK, I played a bit with it and checked new default for macOS and it looks differently (tabs are included in main bar, just like firefox does it now -- next to window close button) and mail bar is the default.
My setup most likely stems from using mail.tabs.autoHide, which I used ages ago (afair under windows, to save space that tabbar used, because I didn't use any tabs so it was one row less) but after resetting that option it to default I still have.
I reset that toolbar and voila - tabs jumped up so in the end it seems it was part of "tab bar" (same like in the default setup). It's a bit of shame that I can't utilize it as after toying with it a bit it turns out that I would only have one row for everything (tabs + icons).
Could you expound on those possible changes to toolbars/addons?
|
||
Comment 11•6 years ago
|
||
(In reply to wojtek from comment #10)
....
Could you expound on those possible changes to toolbars/addons?
|
|
Reporter | |
Comment 12•6 years ago
|
||
A little bit of additional info: in majority of the cases after the restart the addon icon is gone, but once every couple of restarts (launch next day) it stays in the toolbar.
|
|
||
Comment 13•6 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #11)
(In reply to wojtek from comment #10)
....
Could you expound on those possible changes to toolbars/addons?
The changes to add-ons have been announced, and the work on toolbars fizzled out a long time ago so I don't think anything is planned any more.
Also this bug looks very similar to bug 1584160 and I think the patch I wrote for that bug today should fix it.
Description
•