1578528 - Support new text in about:welcome Join message variant

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Update text to support new wording in Join message three variant a, variant b and variant c

https://mozilla.invisionapp.com/share/GNT0C6U53Z8#/screens/374174942_about-Welcome_69

Comment 1

[Punam Dahiya [:pdahiya]]

Needed to support PRD hypothesis 1 and 4: https://docs.google.com/document/d/10TbPuTNJnEk0J_4sdWjT2WFpGhRlF6iQy61tseWYwww/edit#heading=h.y7gzj56ujyk5

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: join-message-70.png

Comment 3

[Punam Dahiya [:pdahiya]]

NI Aaron to provide images shown against Sync and Lockwise in the list.

NI Jim to provide url where 'Learn about the Firefox family of products' in join variant should point to.

Thanks!

Comment 4

[Jim T]

"Learn about" link should point to https://www.mozilla.org/%LOCALE%/firefox/accounts/
Example: https://www.mozilla.org/en-US/firefox/accounts/

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5304

Comment 6

[Punam Dahiya [:pdahiya]]

NI Jim to help clarify if about:welcome first run experiment are planned for all locales or en-US only. This will help determine localization request of the new text. Thanks!

Comment 7

[Jim T]

All Locales, and final language will need to be reviewed with Legal/Trust for that context.

Comment 8

[Punam Dahiya [:pdahiya]]

NI Jim to help setup legal review of join messaging of three variants in bug description. We need final messaging before merging PR in master and submitting for localization. Thanks!

Comment 9

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

Comment 10

[Jim T]

Copy needs a few minor adjustments and then is approved by legal. Note the addition of a single word for Monitor:
https://docs.google.com/document/d/1WeDoWG1c4CHo_5rM_X1wLbJFpiZUlZbLrhkBAGG3Ppc/edit#

Comment 11

[Punam Dahiya [:pdahiya]]

Attachment: Design review screenshots

NI @aaron for design review of new join messaging variants in dev. Thanks!

Comment 12

[Aaron Benson]

These look great!

Comment 13

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/be0251572777

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (71.0a1 Build ID - 20191006214844) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, I can confirm that "modal_variant_a" and "modal_variant_c" are respecting the design specs. However, there is a mismatch between the specs for the "modal_variant_b" and the actual implementation, more exactly the "Supercharge your privacy protection." string is displayed inside the modal instead of the "Supercharge your browser's privacy protection." one.

Punam, could you please confirm if this change is intended or not?

Comment 15

[Punam Dahiya [:pdahiya]]

(In reply to Marius Coman [:mcoman], Experiments QA from comment #14)

I have verified this issue with the latest Firefox Nightly (71.0a1 Build ID - 20191006214844) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, I can confirm that "modal_variant_a" and "modal_variant_c" are respecting the design specs. However, there is a mismatch between the specs for the "modal_variant_b" and the actual implementation, more exactly the "Supercharge your privacy protection." string is displayed inside the modal instead of the "Supercharge your browser's privacy protection." one.

Punam, could you please confirm if this change is intended or not?

Yes, we dropped browser's after legal string review as noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1578528#c10 under alternative headlines. Thanks

Comment 16

[Marius Coman [:mcoman], Ecosystem QA]

Thanks, Punam! Considering the above answer and according to comment 14, I am changing the status of this issue to Verified - Fixed.