Closed Bug 1578682 Opened 5 years ago Closed 2 years ago

Various linters can complain about .eslintrc.js files when run with `--outgoing`, but not when run with `./mach lint .` or `./mach lint *`

Categories

(Developer Infrastructure :: Lint and Formatting, task, P2)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: standard8, Unassigned)

Details

I have the git commit hooks set up for lint. If I'm modifying a .eslintrc.js file, I get a complaint that it doesn't have a valid license:

/Users/mark/dev/gecko/.eslintrc.js
  0   error  No matching license strings found in tools/lint/license/valid-licenses.txt  (license)

I get no errors if I run ./mach lint -l license.

I'm not sure if we should have licenses on these, but either way, they should both error or neither of them error.

Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3
Summary: License formatter complains about .eslintrc.js files when commits change them → Various linters can complain about .eslintrc.js files when run with `--outgoing`, but not when run with `./mach lint .` or `./mach lint *`

Looking at this again, we do now get errors when we run ./mach lint -l license .. I don't think there's anything we can do about ./mach lint -l license * as we hit expansion from the command line.

Note, in bug 1757373, I'm changing the builders to use '.' rather than '*', which will help with this being caught in infra.

Therefore marking as wontfix.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.