1578683 - Turn on ESLint rule prefer-boolean-length-check for toolkit and browser

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1578190 we've landed a rule for removing length comparisons where we're doing == 0 or > 0 (etc).

We would like to start rolling that out, beginning with toolkit/ and browser/

I think rather than adding this to recommended.js to begin with, we should add it to the list in the top-level .eslintrc.js and enable the rule for toolkit/ and browser/.

Comment 1

[Monika Maheshwari [:MonikaMaheshwari]]

Okay will start with that :)

Comment 2

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e616907edd7d43902cfb80bdb35abd19b91b32

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bbabcc98f00
Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1bbabcc98f00