1588872 - Running npm test from mc causes missing lint rule errors

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Kate Hudson :k88hudson]

Running npm test --prefix browser/components/newtab from the root of MC fails because it appears to be missing packages, even after npm installing. No lint errors show up from mach lint. Output looks like this:

...browser/components/newtab/test/xpcshell/test_AboutNewTabService.js
  1:1  error  Definition for rule 'mozilla/prefer-boolean-length-check' was not found  mozilla/prefer-boolean-length-check

Comment 1

[Ed Lee :Mardak]

Bug 1578190 adding prefer-boolean-length-check landed without changing eslint-plugin-mozilla from 2.1.0, which is still the latest published package from 2 months ago.

Comment 2

[Ed Lee :Mardak]

I suppose more from bug 1578683 turning it on for browser/

Comment 3

[Ed Lee :Mardak]

Looks like we can add "mozilla/prefer-boolean-length-check": 0 to browser/components/newtab/.eslintrc and it'll ignore the rule from activity-stream and mozilla-central repositories (even though in the former, it doesn't even know about the rule).

Comment 4

[:Gijs (he/him)]

(In reply to Ed Lee :Mardak from comment #1)

Bug 1578190 adding prefer-boolean-length-check landed without changing eslint-plugin-mozilla from 2.1.0, which is still the latest published package from 2 months ago.

I expect we should fix this either way - Mark?

Comment 5

[Mark Banner (:standard8)]

Ah yes, I'd forgotten about the possible effects on newtab code when we originally enabled it, and I thought adding to just the top-level we'd get away with it.

So I'm just about to attach a patch to set it as default in recommended.js, and disable the other directories where it fails. I'll also bump the versions at the same time so we can publish a new one.

It also reminds me to suggest to Monika that we can probably now enable it for more directories as well :-)

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1588872 - Enable ESLint rule mozilla/prefer-boolean-length-check by default, disable for failing locations. r?Mardak

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c33ead05e1d8
Enable ESLint rule mozilla/prefer-boolean-length-check by default, disable for failing locations. r=Mardak

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c33ead05e1d8

Comment 9

[Mark Banner (:standard8)]

I've just published 2.2.0.