Closed Bug 1578715 Opened 3 months ago Closed 3 months ago

urlbarView is shown below the DevTools's border (splitter) when DevTools are docked to the side

Categories

(Firefox :: Address Bar, defect, P1)

70 Branch
defect
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- verified
firefox71 --- verified

People

(Reporter: fvsch, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

When DevTools are shown and docked to the side (~15% of DevTools sessions), the urlbarView shows below the DevTools's splitter border.

Firefox 70.0b3 and Nightly are affected.

It looks like both elements belong to the same stacking context and are both z-index: 1;.

/* browser/themes/shared/urlbar-autocomplete.inc.css */
.urlbarView:not(.megabar) {
  position: fixed;
  z-index: 1;
  …
}

/* devtools/client/themes/splitters.css */
splitter.devtools-horizontal-splitter,
.devtools-side-splitter {
  …
  position: relative;
  /* Positive z-index positions the splitter on top of its siblings and makes
     it clickable on both sides. */
  z-index: 1;
}

Setting the z-index for urlbarView to any value above 1 seems to fix it.

Points: --- → 1
Priority: -- → P1
Regressed by: 1551598
No longer regressions: 1551598
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 71.1 - Sept 2 - 15
Keywords: regression
Blocks: megabar
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a67d0c7d97aa
Increase urlbarView's z-index. r=adw
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Flags: qe-verify+

Comment on attachment 9092619 [details]
Bug 1578715 - Increase urlbarView's z-index. r=mak

Beta/Release Uplift Approval Request

  • User impact if declined: see comment 1
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: dock devtools to the side and type in the address bar
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial fix
  • String changes made/needed:
Attachment #9092619 - Flags: approval-mozilla-beta?

Comment on attachment 9092619 [details]
Bug 1578715 - Increase urlbarView's z-index. r=mak

Fix for regression in 70, fine for uplift for beta 7.

Attachment #9092619 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have reproduced this issue using Firefox 71.0a1 (2019.09.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 71.0a1 latest nightly and 70.0b7 build from Treeherder, on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.14.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.