Assignee: nobody → rob
Component: General → Build Config
Summary: Error while building on the MacOS sed -i -e "s_^\(SourceRepository=\).*_\1https://hg.mozilla.org/mozilla-central_" \ -e "s/^\(SourceStamp=\).*/\1174361d152923aea2b24226a57cde3099509ed6a/" \ ../../dist/bin/platform.ini sed: -e: No such file or directo → Build failure on macOS post bug 1507754
Fix for macOS build failures.
Attachment #9090574 - Flags: review?(geoff)
Comment on attachment 9090574 [details] [diff] [review] platformini_no_sed.patch No `sed -i`? What are they thinking? :-/ Oh well, that gets rid of the crazy regular expression pattern.
Attachment #9090574 - Flags: review?(geoff) → review+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 9090574 [details] [diff] [review] platformini_no_sed.patch [Approval Request Comment] Regression caused by (bug #): 1507754 User impact if declined: All local builds on macOS fail Testing completed (on c-c, etc.): This has been on central for the past few weeks Risk to taking this patch (and alternatives if risky): Low. This fixes a 100% local build failure rate when the build host is macOS.
Attachment #9090574 - Flags: approval-comm-esr68?
Attachment #9090574 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.