Closed
Bug 1578885
Opened 5 years ago
Closed 5 years ago
ClientEnvironment should use AttributionCode directly, not through Telemetry Environment
Categories
(Toolkit :: General, defect, P1)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: rhelmer, Assigned: rhelmer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1578885 - use AttributionCode directly from ClientEnvironment, rather than Telemetry r?leplatrem
47 bytes,
text/x-phabricator-request
|
Details | Review |
The FirstStartup service added in bug 1576507 runs too early for TelemetryEnvironment to be available, since the latter finishes initializing after the UI is available AFAICT.
This means that currently the attribution code is not available for first-run experiences delivered by Normandy.
Instead, ClientEnvironment (which is used by Normandy as well as Activity Stream and Remote Settings) should use AttributionCode directly. AttributionCode already caches on initialization, so this will be warmed up for when TelemetryEnvironment invokes it later in startup;.
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by rhelmer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d6442adb7b9 use AttributionCode directly from ClientEnvironment, rather than Telemetry r=leplatrem
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•