Closed Bug 1579002 Opened 2 months ago Closed 2 months ago

Retained results: If you start to search, then click outside the bar and back in, the results should be shown again

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox71 --- fixed

People

(Reporter: dao, Assigned: mak)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mak77
Iteration: --- → 71.2 - Sept 16 - 29

So pretty much this is openViewOnFocus, with a couple changes.

The first difference is that we should still open the view in the newtab page, provided there is a search string. This is compatible with the current behavior for topsites since it doesn't overlap it.

The second difference is relative to private browsing, we don't open the view for top sites in PB mode, it's unclear whether we should do the same in this case, so I'm asking Verdi on Slack.

(In reply to Marco Bonardo [::mak] from comment #1)

So pretty much this is openViewOnFocus, with a couple changes.

Yeah, I think it should also depend on that mode actually being enabled. I'm not sure what the plan is there beyond the top sites experiment; are we considering enabling open-view-on-focus in 71?

Depends on: 1547299

Verdi clarified it should work the same in PB mode.

I was problably wrong about the overlapping though, I can't just flip the pref.
If there's a search string and the megabar is enabled, we can surely open the view.
But, if there's no search string, we should open the view only on request (like for the topsites experiment).
I can likely reuse the same hook points, just not the openViewOnFocus pref.

(In reply to Dão Gottwald [::dao] from comment #2)

Yeah, I think it should also depend on that mode actually being enabled. I'm not sure what the plan is there beyond the top sites experiment; are we considering enabling open-view-on-focus in 71?

I think openViewOnFocus will pretty much relate to the empty-string case and we'll likely flip that pref once we decide what to show in that case (top sites? something else). This depends on the experiments result.

Depends on: 1582505
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/d89319819e43
Retained results: megabar should shown again pending search results on refocus. r=dao
Blocks: 1584274
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Blocks: 1586351
You need to log in before you can comment on or make changes to this bug.