BlockAboutConfig policy does not block about:config in Preferences tab
Categories
(Thunderbird :: Preferences, defect, P5)
Tracking
(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)
People
(Reporter: kontakt.luck, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
1.19 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
Set REG_DWORD in Registry: HKLM\SOFTWARE\Policies\Mozilla\Thunderbird - BlockAboutConfig to 1
Open Settings > Advanced > Edit Configuration
Actual results:
Window About:config opened
Expected results:
Blocked Site dialog should appear
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Where is it documented that this should work?
(NI for Geoff to attract attention, not to answer the specific question. Seems to be a policy thing.)
Reporter | ||
Comment 2•5 years ago
|
||
Support for the policy engine has been added in Thunderbird 68.
Configurable policies are found here: https://searchfox.org/comm-central/source/mail/components/enterprisepolicies/schemas/policies-schema.json
Assignee | ||
Comment 3•5 years ago
|
||
That's not good, I wonder if this is actually a hole in the policy framework itself. about:config
should not open anywhere, which works correctly in a content tab, but not in the <browser>
inside the preferences tab.
We should also remove the button which leads to it, which would solve the problem.
Comment 4•5 years ago
|
||
We do block about:config in Firefox, so something must be missing in the TB implementation.
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
I think you've missed my point Mike. Presumably the blocking is done somewhere in the page loading code, since a blocked page is replaced by about:neterror
. But this doesn't happen for the same page loaded in a <browser>
inside our preferences page.
Comment 8•5 years ago
|
||
I think you've missed my point Mike. Presumably the blocking is done somewhere in the page loading code, since a blocked page is replaced by about:neterror. But this doesn't happen for the same page loaded in a <browser> inside our preferences page.
No, I understood. Content policy must not be getting loaded for that browser. It's done here:
https://searchfox.org/comm-central/source/mail/components/enterprisepolicies/Policies.jsm#657
It's less problematic in Thunderbird because there is no URL bar, but we should still figure it out.
Comment 9•5 years ago
|
||
Looks like csp.about_uris_without_csp hasn't been kept up to date: https://searchfox.org/comm-central/rev/7a16820ae8c33db28e912940437995f360bcfffb/mail/app/profile/all-thunderbird.js#356
Comment 10•5 years ago
|
||
Comment on attachment 9090874 [details] [diff] [review] 1579019-hide-about-config-esr1.diff Review of attachment 9090874 [details] [diff] [review]: ----------------------------------------------------------------- I'd rather disable, or maybe better just let the error page show what's going on.
Updated•5 years ago
|
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4e5fad04693c
Disable "Config Editor" button if about:config is blocked by policy. r=mkmelin
Updated•5 years ago
|
Comment 14•5 years ago
|
||
TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/9de9ab2eab3b7d40bd1df936283420d05902f9b1
Updated•5 years ago
|
Comment 15•5 years ago
|
||
TB 68.1.1 or TB 68.2:
https://hg.mozilla.org/releases/comm-esr68/rev/5fa4de11c596741664838365f52201176d020e44
Assignee | ||
Updated•5 years ago
|
Description
•