1579261 - IsSameOriginWithAllParentDocs in MediaDevices.cpp probably doesn't work as expected in Fission

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

here. Since it uses GetCrossDocParentNode, it can't walk node tree across the cross-origin document boundaries.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Jan-Ivar, would you mind taking a first pass at triaging this?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Looks like this would affect our cross-origin getUserMedia and getDisplayMedia telemetry probes.

The fission meta bug is P3 so I used that.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

When we circle back to this, we should evaluate if we have the data we wanted from the probes. If so, the probes and the function in question can be removed.

Comment 4

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 5

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

What functionality is broken in Fission by this bug? kmag says this bug should be relatively easy to fix by walking the BrowsingContext tree.

Comment 6

[Chris Peterson [:cpeterson]]

Jan-Ivar, should this bug block shipping Fission MVP to Release? If so, should it also block enabling Fission in Nightly?

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Feature policy has been enabled, so these probes have served out their purpose, and can be removed. I'll add a patch to remove them.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #7)

Feature policy has been enabled, so these probes have served out their purpose, and can be removed. I'll add a patch to remove them.

Thanks. In that case, this bug doesn't need to block shipping Fission. :)

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1579261 - Remove getUserMedia, getDisplayMedia & mozGetUserMedia cross-origin probes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7974edfa0a32
Remove getUserMedia, getDisplayMedia & mozGetUserMedia cross-origin probes. r=ng

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7974edfa0a32