Closed Bug 1647416 Opened 5 years ago Closed 5 years ago

Fix use of GetCrossDocParentNode in MediaDevices.cpp:IsSameOriginWithAllParentDocs and GetUserMedia/EnumerateDevices

Categories

(Core :: WebRTC, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1579261

People

(Reporter: kmag, Unassigned)

References

Details

Under Fission, GetCrossDocParentNode will never walk to a cross-origin parent document, and will therefore never detect a cross-origin ancestor. The code needs to walk WindowContexts instead, and assume any cross-process context is cross-origin.

Summary: Fix use of GetCrossDocParentNode in MediaDevices.cpp:IsSameOriginWithAllParentDocs → Fix use of GetCrossDocParentNode in MediaDevices.cpp:IsSameOriginWithAllParentDocs and GetUserMedia
Summary: Fix use of GetCrossDocParentNode in MediaDevices.cpp:IsSameOriginWithAllParentDocs and GetUserMedia → Fix use of GetCrossDocParentNode in MediaDevices.cpp:IsSameOriginWithAllParentDocs and GetUserMedia/EnumerateDevices
Component: Audio/Video → WebRTC
See Also: → 1647407

Nico, it looks like you added the call in Bug 1528078, would you be comfortable updating it?

https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/dom/media/MediaDevices.cpp#35

Flags: needinfo?(na-g)
Severity: -- → S3

Jan-Ivar, that code in my patch is something that you were using elsewhere if I remember correctly. I thought you may want to see this just in case.

Flags: needinfo?(na-g) → needinfo?(jib)
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jib)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.