Closed
Bug 1579295
Opened 5 years ago
Closed 5 years ago
Change <body> tag to <main> for shape-outside tests
Categories
(Core :: Layout: Floats, task, P3)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Per hiro's experimental patch in Bug 1102175 Comment 28, many shape-outside tests in layout/reftests/w3c-css/submitted/shapes1/ begin to fail. That is because I use writing-mode anddirection on <body> in these tests, which accidentally rely on bug 1102175 to pass. I'd like to change them to <main>.
|
Assignee | |
Comment 1•5 years ago
|
||
To avoid Bug 1102175 when specifying "direction" or "writing-mode" on
<body>, replace <body> with <main>. This patch doesn't change the
meaning of the tests.
Except for shape-outside-margin-box-border-radius-008.html, which is
modified manually, all the other files are modified by the follow Python
3 script.
import fileinput
import glob
open_tag_before = '<body class="container">'
open_tag_after = '<main class="container">'
end_tag_before = '</body>'
end_tag_after = '</main>'
match_files = 'layout/reftests/w3c-css/submitted/shapes1/*.html'
with fileinput.FileInput(glob.glob(match_files), inplace=True) as f:
found_open_tag = False
for line in f:
if not found_open_tag:
line_open_tag = line.replace(open_tag_before, open_tag_after)
if line_open_tag != line:
print(line_open_tag, end='')
found_open_tag = True
else:
print(line, end='')
else:
# Continue search for end tag
line_end_tag = line.replace(end_tag_before, end_tag_after)
if line_end_tag != line:
print(line_end_tag, end='')
found_open_tag = False
else:
print(line, end='')
|
|
Assignee | |
Updated•5 years ago
|
Blocks: shape-outside
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bf24d54d1abc
Replace <body> with <main> for shape-outside tests. r=jfkthame
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
|
Assignee | |
Comment 5•5 years ago
|
||
The test file is replaced manually in the main patch.
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a35315b1d467
followup - Replace <body> with <main> for shape-outside-margin-box-border-radius-008-ref.html. r=jfkthame
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•