1579420 - Enable ESLint rule no-async-promise-executor on disabled locations for browser and toolkit

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

When we upgraded to ESLint 6, we disabled the no-async-promise-executor rule for various files as it wasn't a quick enable.

This bug is for browser/ and toolkit/

Some notes about this rule (from ESlint's site):

The Promise executor function can be an async function. However, this is usually a mistake, for a few reasons:

• If an async executor function throws an error, the error will be lost and won’t cause the newly-constructed Promise to reject. This could make it difficult to debug and handle some errors.
• If a Promise executor function is using await, this is usually a sign that it is not actually necessary to use the new Promise constructor, or the scope of the new Promise constructor can be reduced.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1579420 - Fix ESLint no-async-promise-executor issues in extensions code. r?rpl

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1579420 - Fix remaining ESLint no-async-promise-executor issues in browser/ and toolkit/. r?Mossop

Depends on D45009

Comment 3

[Mark Banner (:standard8)]

Try push of latest changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1009ca9870c5663c1103e622f17066d54b829e8e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/658fefe3ee08
Fix ESLint no-async-promise-executor issues in extensions code. r=rpl
https://hg.mozilla.org/integration/autoland/rev/ee304e0ae81b
Fix remaining ESLint no-async-promise-executor issues in browser/ and toolkit/. r=mossop

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/658fefe3ee08
https://hg.mozilla.org/mozilla-central/rev/ee304e0ae81b