1579414 - [meta] Enable ESLint rule no-async-promise-executor everywhere on the tree

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

When we upgraded to ESLint 6, we disabled the no-async-promise-executor rule for various files as it wasn't a quick enable.

This bug is for tracking the bugs to get that turned on fully.

Some notes about this rule (from ESlint's site):

The Promise executor function can be an async function. However, this is usually a mistake, for a few reasons:

• If an async executor function throws an error, the error will be lost and won’t cause the newly-constructed Promise to reject. This could make it difficult to debug and handle some errors.
• If a Promise executor function is using await, this is usually a sign that it is not actually necessary to use the new Promise constructor, or the scope of the new Promise constructor can be reduced.

Comment 1

[Mark Banner (:standard8)]

Looks like we fixed this in the bugs this depends on.